Skip to content

Upstream changes widgets - #108

Merged
2 commits merged into
alphafrom
Upstream_changes_widgets
May 28, 2020
Merged

Upstream changes widgets#108
2 commits merged into
alphafrom
Upstream_changes_widgets

Conversation

@Mohammer5

Copy link
Copy Markdown
Contributor

Contains the changes of the two following commits in the ui-widgets repository:

  • fix: escape regex special chars in search
  • fix: correctly select and use user locale and application title text

@Mohammer5
Mohammer5 requested review from a user, HendrikThePendric and amcgee May 28, 2020 07:51
@Mohammer5
Mohammer5 requested a review from a team as a code owner May 28, 2020 07:51
@cypress

cypress Bot commented May 28, 2020

Copy link
Copy Markdown



Test summary

468 0 0 0


Run details

Project ui
Status Passed
Commit 2f11c96
Started May 28, 2020 8:11 AM
Ended May 28, 2020 8:20 AM
Duration 08:54 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Mohammer5
Mohammer5 force-pushed the Upstream_changes_widgets branch from 562242a to 2f11c96 Compare May 28, 2020 08:08

@amcgee amcgee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code changes and they seem fine to me, haven't tested locally

@ghost
ghost merged commit fc47e22 into alpha May 28, 2020
@ghost
ghost deleted the Upstream_changes_widgets branch May 28, 2020 09:06
@dhis2-bot

Copy link
Copy Markdown
Contributor

@dhis2-bot

Copy link
Copy Markdown
Contributor

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants