This repository was archived by the owner on Nov 6, 2020. It is now read-only.
feat: wrap contents with a link element when href or onClick is given - #354
Merged
Conversation
varl
approved these changes
Jul 19, 2019
dhis2-bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
# [3.7.0](dhis2/ui@v3.6.3...v3.7.0) (2019-07-19) ### Features * wrap contents with a link element when href or onClick is given ([#354](dhis2/ui#354)) ([9e8d3f0](dhis2/ui@9e8d3f0))
Contributor
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change the navigation will be semantically correct, rendering
aelements when there's either ahrefor anonClickcallback.Said element will be a
spanwhen neither if given (i. e. so aSwitchcan be renderen inside aMenuItem)This PR will also add a height value to the
Switchso it's not cut off anymore when inside elements withoverflow: hidden(see currentMenu > Defaultstorybook demo)