chore: fix cli-style useEffect exhaustive deps warnings - #753
Merged
Conversation
Mohammer5
approved these changes
Oct 4, 2022
| if (alertManagerAlerts.length > 0 || alertStackAlerts.length > 0) { | ||
| setAlertStackAlerts( | ||
| if (alertManagerAlerts.length > 0) { | ||
| setAlertStackAlerts((alertStackAlerts) => |
Contributor
There was a problem hiding this comment.
Very minor nitpick: This variable has the same name as the variable returned by useState in the outer scope. Maybe currentAlertStackAlert (or another name that ensures that the reader immediately recognizes that this is a different variable)?
Contributor
Author
There was a problem hiding this comment.
Yeah that's a nice readability improvement 👍
amcgee
commented
Oct 4, 2022
Contributor
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cli-style warnings and clean up useEffect calls to make logic a bit cleaner