feat: detect server version, use latest available api version#470
Merged
Conversation
varl
approved these changes
Oct 12, 2020
varl
left a comment
varl
left a comment
Contributor
There was a problem hiding this comment.
Very nice feature addition! Also great to get rid of the hardcoded fallback to 32. 👍
dhis2-bot
added a commit
that referenced
this pull request
Oct 12, 2020
# [5.3.0](v5.2.2...v5.3.0) (2020-10-12) ### Features * detect server version, use latest available api version ([#470](#470)) ([ef92456](ef92456))
Contributor
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change deprecates the
DHIS2_API_VERSIONenvironment variable, which would previously hard-code the api version to be used by every runtime query in the application. The previous default was 32, which is several versions behind at this point.After this change, the App Shell makes a single call to an un-versioned API endpoint
/api/system/infoto detect the version of the DHIS2 instance (as well as some other immutable system information). The server version is then parsed to determine the "latest" version of the DHIS2 API to use - equal to the minor server version (this may need to change in the future, if we slow down breaking API changes).Additionally, the results of the
/system/infoall are saved into thesystemInfoproperty of the App Runtime config service (dhis2/app-runtime#652), and the parsed server version (major,minor,patch,tag) are saved in theserverVersionproperty.Finally, this cleans up and refactors the folder hierarchy of the
app-adapterpackage.I added some test and noticed that neither build nor test were previously run on CI, so I updated the GHA workflow to run lint/build/test in parallel in a single workflow.