Repository navigation
docs(filings): acceptance_datetime from get_filings() is not reliably UTC (#1501) - #1502
Merged
Merged
Conversation
… UTC (#1501) EntityFiling.acceptance_datetime comes from acceptanceDateTime in SEC's submissions JSON, which carries a trailing Z and is parsed as UTC (edgar/dates.py::parse_acceptance_datetime). SEC does not reliably write it in UTC: Apple's 10-Q 0000320193-26-000020 was accepted at 06:01:02 ET (10:01:02 UTC, per the SGML header and SEC's index page) and read 14:01:02 UTC on 2026-10-08. The reporter measured offsets that vary by filer and by day, so no fixed correction exists. This is the documentation half for 5.62.0: the class docstring and the filing guide name the problem and point to filing.header.acceptance_datetime, which reads the filing's own SGML header. Changing the value itself is a value change and is left to 6.0 (bead edgartools-cewy). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
EntityFiling.acceptance_datetime, the value on every filing fromCompany(...).get_filings(), comes fromacceptanceDateTimein SEC's submissions JSON. SEC labels that field UTC, but for some filers it is hours off. Apple's 10-Q0000320193-26-000020was accepted at 06:01:02 ET (10:01:02 UTC). On 2026-10-08 it read2026-07-31 14:01:02+00:00. I confirmed that live today, andfiling.header.acceptance_datetimereturned2026-07-31 06:01:02. The offset varies by filer and by day, so it can't be corrected after the fact.This PR is the documentation half, for 5.62.0:
EntityFilingclass docstring gains anacceptance_datetimeentry. It says the value is not reliably UTC and points tofiling.header.acceptance_datetimefor a precise time, noting the extra request that costs.docs/guides/working-with-filing.mdgains the same note under the EntityFiling properties example.The value itself is unchanged. Fixing it (reading the header, or dropping or renaming the JSON-derived value) changes values users already see, so it's left for 6.0 and tracked in bead
edgartools-cewy.Refs #1501. This doesn't close the issue, because the value fix is still to come.
Verification
assemble_changelog.py --check: 15 fragments ready, and this one is 354 characters.ruff check edgar/entity/filings.py: clean.🤖 Generated with Claude Code