Skip to content

Run CI on visionOS#83

Merged
dfed merged 6 commits into
mainfrom
dfed--visionos
Feb 1, 2024
Merged

Run CI on visionOS#83
dfed merged 6 commits into
mainfrom
dfed--visionos

Conversation

@dfed

@dfed dfed commented Jan 31, 2024

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f4d72c) 99.07% compared to head (b18e80f) 99.07%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          11       11           
  Lines         538      538           
=======================================
  Hits          533      533           
  Misses          5        5           

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
- name: Bundle Install
run: bundle install
- name: Select Xcode Version
run: sudo xcode-select --switch /Applications/Xcode_15.0.1.app/Contents/Developer

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while 15.0.1 is supported by the macOS 14 machines, I've seen a ton of spurious failures on those machines so I'm bumping to 15.2 for better support

Comment thread CacheAdvance.podspec
s.homepage = 'https://github.com/dfed/CacheAdvance'
s.authors = 'Dan Federman'
s.source = { :git => 'https://github.com/dfed/CacheAdvance.git', :tag => s.version }
s.swift_version = '5.6'

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We compile on Swift 5.6, 5.7, 5.8, and 5.9. To validate that we work on visionOS, we have to lint on Swift 5.9, which we can't do if our podspec specifies an earlier source.

@dfed dfed self-assigned this Feb 1, 2024
@dfed dfed marked this pull request as ready for review February 1, 2024 16:19
@dfed dfed merged commit 6e380c9 into main Feb 1, 2024
@dfed dfed deleted the dfed--visionos branch February 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant