harden(reader): close depth-guard mutation-coverage gaps#173
Merged
Conversation
PIT on the reader (-P pitest) flagged six survivors in the depth/bounds guards added by the hardening work. Each marks a real coverage hole, not an arbitrary edge: - convertDType recursion was only exercised through the List arm, so the depth+1 increment on the Struct / FixedSizeList / Extension arms could be mutated away undetected. Parameterize the dtype depth-bomb over all four NestKind variants. - Pin the convertDType and convertArrayNode depth caps at their exact boundary (limit parses, limit+1 throws), mirroring the existing layout-depth tests. - Pin parseBlobs treating a present-but-empty dtype blob as a null dtype. Reader PIT is now 0 survivors (112 killed, 1 timed-out, 100% test strength). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172. Ran PIT (
-pl reader -am -P pitest verify -DskipITs) on the depth/bounds guards added by the hardening work; it surfaced six survivors, each a real coverage hole.Fixes
convertDType:239/249/253(MathMutatordepth + 1)List, leaving theStruct/FixedSizeList/Extensionrecursion arms untestedDTypeDepthBombSecurityTestover a newNestKindenum (all four arms)convertDType:200/convertArrayNode:85(depth >→>=)parseBlobs:120(byteSize() > 0→>= 0)Result
Reader PIT: 0 survivors — 112 killed, 1 timed-out, 100% test strength (was 6 survived / 95%).
Tests only; no production change.
🤖 Generated with Claude Code