test(zstd): re-enable dictionary-compressed zstd.vortex interop (#104)#171
Merged
Conversation
Dictionary-compressed vortex.zstd decode landed earlier via the native libzstd FFM bindings, but the Rust-vs-Java comparison still excluded the zstd.vortex fixture. Re-enable it and teach the test's string-column collector to unwrap a MaskedArray (nullable Utf8 now decodes as MaskedArray over a VarBin values child), so nullable_utf8 byte-length stats are compared too. The fixture now reads end-to-end and matches the Rust reference. Closes #104 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #104. Dictionary-compressed
vortex.zstddecode already landed (nativelibzstdshared-dictionary support via the FFM bindings), but the Rust-vs-Java reader comparison still excluded thezstd.vortexfixture. This re-enables it.What changed
RustJavaReaderComparisonIntegrationTest— addedzstd.vortexback to the fixture list (removed the stale "dictionary mode not yet implemented" exclusion).stringByteLengthnow unwraps aMaskedArrayto itsVarBinvalues child, so nullable Utf8 columns (which decode asMaskedArraysince fix(writer): unify nullable utf8/binary on the NullableData carrier #168) are counted. Without this the fixture'snullable_utf8column was dropped from the string-stat comparison.Fixedentry.Testing
RustJavaReaderComparisonIntegrationTest#rust_vs_javaReader_statsMatch— 26/26 fixtures green, includingzstd.vortex(dict-compressed, read end-to-end, matches the Rust reference).🤖 Generated with Claude Code