test(integration): skip fixture download on transient S3 5xx#164
Merged
Conversation
The Rust-interop tests download fixtures from S3. A transient 500 on a single object aborted the whole CI build (macos-25 cell) even though the fixture and decoder were fine. Inspect the HTTP response code and treat a 5xx as a skipped assumption instead of a hard error; a 4xx (fixture truly gone) still fails, since that is a real signal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainwent red (macos-25 CI cell) on commit 5adb63e — not a code regression. The Rust-interop integration tests download fixtures from S3, and a single object returned a transient HTTP 500:Every other matrix cell (ubuntu-25, macos-26, windows) passed.
What
downloadIfMissingnow inspects the HTTP response code:assumeTrue(false, ...)→ test skipped (S3 infrastructure noise, not an interop regression).Applied to both
RustWritesJavaReadsIntegrationTestandPcoFixtureInspectionIntegrationTest(identical latent flake).Verified locally:
RustWritesJavaReadsIntegrationTest4/4 pass,BUILD SUCCESS.🤖 Generated with Claude Code