test: OHLC data dedup + calcite coverage for Sonar gate#162
Merged
Conversation
Drop the integration OhlcGenerator/OhlcBatch adapter and switch the JNI round-trip callers (FileSizeComparisonIntegrationTest, JavaWritesRustReadsIntegrationTest) to core.testing.OhlcData.Batch directly, so the OHLC shape is single-sourced rather than mirrored. Verified against the JNI integration suite (OHLC round-trips + file-size comparison, native libs present). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…r new-coverage gate) SonarCloud quality gate was ERROR: new_coverage 74% < 80%, concentrated in the new calcite adapter. Add tests for the uncovered paths — no production changes: - FilterPushDownTest: JDBC WHERE over every supported comparison, Utf8/float literal coercion, multi-conjunct AND, non-pushable bool/bare-ref predicates (exercises toRowFilter/binary/collectColumns). - AggregateRuleBranchTest: Hep planner asserts rewrite-to-Values vs abandon for COUNT(*), COUNT(col), SUM (no stat), MIN(varchar), MIN(expr), GROUP BY. - VortexAdapterCoverageTest: missing-file UncheckedIOException paths, reset()/ close-with-open-chunk, i32/f32 sums, non-numeric-column throw. calcite new-code coverage 74% -> 88.5% lines / 83.2% line+branch units. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only changes:
OhlcData.Batch; drop the duplicateOhlcGenerator/OhlcBatchshape (TODO follow-up).new_coveragegate (was 74% < 80%). AddsFilterPushDownTest,AggregateRuleBranchTest, extendsVortexAdapterCoverageTest. calcite new-code 74% → 88.5% lines / 83.2% line+branch units. No production changes.🤖 Generated with Claude Code