Skip to content

feat!: remove Pro pack delivery (patina pack, /api/packs) - #953

Merged
devswha merged 1 commit into
devfrom
bot/remove-pro-packs
Sep 26, 2026
Merged

devswha merged 1 commit into
devfrom
bot/remove-pro-packs

Conversation

@devswha

@devswha devswha commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

Removes Pro pack delivery. The private pack repository devswha/patina-pro-packs has served {"packs": []} since 2026-07-12, when its only pack (ko-doc-structure) was retired after Study 2, so patina pack list/install and /api/packs deliver nothing. Policy: docs/WORKFLOW.md

No Issue: part of the owner-requested 2026-09-26 dead-feature sweep (Tier 2 "Pro packs"); the owner's standing instruction for that sweep is to remove anything removable.

  • Deleted src/commands/pack.js, src/pack-handler.js, api/packs.js, docs/PRO-PACKS.md, tests/unit/pack-command.test.js, tests/unit/pack-handler.test.js.
  • patina pack … now fails with the same usage error shape as the retired patina pattern / patina aside commands: patina pack was removed, exit 2, no fetch, no output.
  • src/cli/args.js help, docs/ARCHITECTURE.md, docs/CLI.md, docs/FLAG-PARITY.md, docs/PATTERNS.md, docs/COMPARISON.md (patina row), .env.example, the src/loader.js comment, and scripts/check-architecture.mjs (server-secret list) no longer mention packs.
  • tests/unit/entitlement-ip-admission.test.js keeps the /api/rewrite end-to-end admission tests and drops the /api/packs twin.

Scope and risk

  • Contract impact: retirement of the patina pack subcommand, the /api/packs endpoint, the CLI env vars PATINA_LICENSE_KEY / PATINA_PACKS_URL, the server env vars PATINA_PACKS_*, and the license-key / packs-url config keys (now ignored, like any unread key).
  • Not changed: hosted Pro license validation (src/entitlement*.js, /api/rewrite), custom/patterns and custom/personas loading, detection, scoring, prompts, the skill.
  • Size: 18 files, +29 / −1061; 6 whole-file deletions carry most of it.
  • Owner follow-ups after the release deploys: delete the Vercel env PATINA_PACKS_GITHUB_TOKEN (and any PATINA_PACKS_*), revoke its fine-grained PAT, archive devswha/patina-pro-packs.

Verification

  • New test removed pack command rejects as a usage error without fetching or output failed on the unmodified tree (2 pass / 1 fail) and passes after the change.
  • npm test → 0 (2118 tests: 2117 pass, 1 skipped, 0 fail)
  • npm run lint → 0 (architecture: 107 modules, 347 edges, 0 violations)
  • npm run release:check, npm run check:no-private-assets, npm run dogfood, git diff --check → 0
  • node bin/patina.js pack list and pack install --all → exit 2 with the retirement message; --help has no pack lines.
  • Base: origin/dev 9108a63.

Release and rollback

  • Semver impact: removes a CLI subcommand and an HTTP endpoint. Per the 2026-09-26 owner policy the next release stays a minor (9.1.0); the release CHANGELOG must state this removal in its semver rationale.
  • Rollback: revert the squash commit. No data migration.

The private pack repository has served an empty manifest since
2026-07-12, when its only pack was retired after Study 2, so the CLI
command and the endpoint delivered nothing.

`patina pack` now fails with the same "was removed" usage error as the
retired `pattern` and `aside` commands (exit 2). Hosted Pro license
validation and custom/ pattern and persona loading are unchanged.
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
patina Ready Ready Preview Sep 26, 2026 8:12am UTC

Request Review

@devswha

devswha commented Sep 26, 2026

Copy link
Copy Markdown
Owner Author

Independent review (read-only, one pass): APPROVE

Reviewer: separate read-only gate-review agent (did not write the change).

  • No blocker, major, or minor findings.
  • Nit: no CHANGELOG entry. Intentional; release prep writes it (as with feat!: remove --preview/--ocr/--serve and --xliff from the CLI #951). The 9.1.0 notes must list the removed patina pack, /api/packs, the CLI PATINA_LICENSE_KEY, PATINA_PACKS_*, and the now-ignored license-key / packs-url keys.
  • Note: owner follow-ups outside the repo (Vercel PATINA_PACKS_* env, the pack repo token, archiving devswha/patina-pro-packs) are listed in the PR body.

Verified by the reviewer: no current-behavior leftovers (only CHANGELOG/docs/research mentions remain), hosted Pro license validation untouched, check-architecture 107 modules / 0 violations, targeted tests 8/8, patina pack list → exit 2 with the retirement message. CI: all checks green.

@devswha
devswha marked this pull request as ready for review September 26, 2026 08:15
@devswha
devswha merged commit f18fc2f into dev Sep 26, 2026
8 checks passed
@devswha
devswha deleted the bot/remove-pro-packs branch September 26, 2026 08:15

This branch was successfully deployed

1 active deployment
Preview — 748a0631 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant