Repository navigation
fix(account): end a row's other sessions when a link moves it to another key - #2931
Merged
Merged
Conversation
…her key A session signed in with a row's old relay key kept drive access after the row was linked to the account key, until it reconnected. A link now ends the row's other sessions with auth_changed; the linking session goes on (with no member's rights) until it signs in again with the new key. Closes #2864
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
Local merge gate (owner-approved): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
linkmoves a row from its old relay key to the account key. Other sessions that had signed in with the old key kept drive access (terminals, settings) until they reconnected. Member actions already needed the row's current key.A link now ends the row's other sessions with
auth_changedonce it is written. The linking session goes on, with no member's rights, until it signs in again with the new key. The PC's other devices are untouched.Closes #2864
Validation
bun run check fast: all ok (typecheck, build, unit tests 11754 pass, 0 fail).bun test server/account/ server/relay/ server/device-access.contract.test.ts: 247 pass.