Repository navigation
fix(account): let a watching member leave with a remove signed by its own key - #2930
Merged
Merged
Conversation
… own key The contract lets a device leave the account by signing the remove of its own key, but the PC took records only from drive members, so a device that only watched could never leave. A remove signed by the key it removes now applies for a member of any role; a watching member still cannot remove another device. Part of #2878 (the PC side; retrying a failed approval is the approving client's).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
Local merge gate (owner-approved): |
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The account contract lets a device leave the account by signing the
removeof its own key (docs/account.md, "Aremovemay be signed by the key it removes"). The PC, though, took records only from drive members, so a device that only watched a PC could never leave there: its ownremovewas refused (signer_not_member).A
removesigned by the key it removes now applies for a member of any role. A watching member still cannot remove any other device.This is the PC side of #2878. Retrying an approval that failed after the PC let the device in belongs to the approving client and is tracked there.
Validation
bun run check fast: all ok (typecheck, build, unit tests 11747 pass, 0 fail).removefrom a watching member is accepted.bun test server/account/ server/relay/ server/device-access.contract.test.ts: 249 pass.