Skip to content

chore(remote): raise the remote bundle version to 10 - #282

Merged
devswha merged 2 commits into
mainfrom
chore/remote-bundle-v10
Oct 1, 2026
Merged

devswha merged 2 commits into
mainfrom
chore/remote-bundle-v10

Conversation

@devswha

@devswha devswha commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Fixes #256.

Raises REMOTE_BUNDLE_VERSION from 9 to 10, so that remote PCs (Windows PCs included) get the bridge-side fixes merged since remote-v9: #235, #243, #249, #251, #264, #265, #267, #278, #281 and the rest of git log remote-v9..main -- server shared.

server/machines.test.ts named the remote-v9 directory literally and failed on the new number; it now reads the constant.

Order, from docs/remote-pcs.md

  1. Merge this.
  2. Push the remote-v10 tag on main: the Remote PC bundles workflow builds, smoke-tests and publishes the five archives and manifest.json.
  3. Only then release the app: an app that carries the new number finds no remote-v10 manifest before step 2, and every connected PC's bridge counts as incompatible until it is updated.

Checked

bun run typecheck, bun run test:unit (734 pass). The bundle build and smoke run in this PR's Remote PC bundles checks.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
CONTRIBUTING.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a5aae548-f343-4723-8bfd-f8cb8c1a49cd

📥 Commits

Reviewing files that changed from the base of the PR and between e527065 and 16d6821.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • server/machines.test.ts
  • shared/machines.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Updates
    • Windows PCs now use the remote-v10 runtime, bringing them the server-side fixes added since remote-v9.
    • PCs still connected through the remote-v9 bridge continue to update as before.

Walkthrough

The remote bundle version changes from 9 to 10. The Windows runtime-directory test now uses the shared version constant, and the Unreleased changelog describes the remote-v10 fixes.

Changes

Remote bundle version

Layer / File(s) Summary
Update remote bundle version
shared/machines.ts, server/machines.test.ts, CHANGELOG.md
The shared runtime version is set to 10. The Windows test derives its expected runtime directory from that constant. The changelog records the remote-v10 fixes and notes that remote-v9 connections retain their previous update behavior.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 16d68

Remote PCs can update from v9 to v10; publish the remote-v10 bundle before releasing the app version that uses it.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 16d68

The change preserves the inspected verification and bridge-ownership controls, but intentionally makes older bridges incompatible. Version-10 bundles must be published before the corresponding app release. Actual publication and update execution were not verified, so the remaining rollout uncertainty prevents a minimal-risk assessment.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The compatibility transition can affect every registered remote PC still running version 9, across the five supported platform bundles. The inspected automatic update path uses each PC's existing SSH authorization; the version change does not itself grant access to additional remote accounts.

Trust Boundaries and Controls

  • observed — Runtime bytes remain subject to manifest-version and SHA-256 checks on the connection server, with a second checksum check on the destination before extraction. Independently managed bridges are excluded from updater shutdown authority. These are preserved controls, not proof that a compromised trusted publisher or remote account is harmless.

Resilience and Maintainability Implications

  • observed — Unavailable or incompatible bundles fail before the running bridge is stopped. Concurrent downloads share a checksum-keyed operation, remote installations take a lock, and generation checks prevent a cancelled or superseded connection from publishing its endpoint. These controls contain inspected failure paths but do not demonstrate automatic rollback after every restart or activation failure.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the primary change: increasing the remote bundle version to 10.
Description check ✅ Passed The description explains the problem, resulting behavior, release order, linked issue, and validation results. It provides the required Change and Validation information, although it uses a Checked he…
Linked Issues check ✅ Passed PR #282 satisfies the coding requirements in directly linked issue #256. shared/machines.ts sets REMOTE_BUNDLE_VERSION to "10", which selects the remote-v10 runtime for bridge setup and versio…
Out of Scope Changes check ✅ Passed The reviewed changes stay within issue #256. The version constant enables delivery of bridge fixes since remote-v9; the test update validates the new version; and the changelog documents the runtime…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@devswha
devswha merged commit 6534c30 into main Oct 1, 2026
11 checks passed
@devswha
devswha deleted the chore/remote-bundle-v10 branch October 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows PCs still run remote-v9: the Windows New session fix (#251) and later bridge fixes never reach them

1 participant