Repository navigation
chore(remote): raise the remote bundle version to 10 - #282
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe remote bundle version changes from 9 to 10. The Windows runtime-directory test now uses the shared version constant, and the Unreleased changelog describes the remote-v10 fixes. ChangesRemote bundle version
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Remote PCs can update from v9 to v10; publish the remote-v10 bundle before releasing the app version that uses it. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change preserves the inspected verification and bridge-ownership controls, but intentionally makes older bridges incompatible. Version-10 bundles must be published before the corresponding app release. Actual publication and update execution were not verified, so the remaining rollout uncertainty prevents a minimal-risk assessment. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Fixes #256.
Raises
REMOTE_BUNDLE_VERSIONfrom 9 to 10, so that remote PCs (Windows PCs included) get the bridge-side fixes merged sinceremote-v9: #235, #243, #249, #251, #264, #265, #267, #278, #281 and the rest ofgit log remote-v9..main -- server shared.server/machines.test.tsnamed theremote-v9directory literally and failed on the new number; it now reads the constant.Order, from docs/remote-pcs.md
remote-v10tag onmain: the Remote PC bundles workflow builds, smoke-tests and publishes the five archives andmanifest.json.remote-v10manifest before step 2, and every connected PC's bridge counts as incompatible until it is updated.Checked
bun run typecheck,bun run test:unit(734 pass). The bundle build and smoke run in this PR's Remote PC bundles checks.