Repository navigation
fix(gjc): recover conversations from verified managed sessions - #2552
Draft
Haeminway1 wants to merge 1 commit into
Draft
Haeminway1 wants to merge 1 commit into
Haeminway1 wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
|
Heads-up: this repository now asks every contributor to sign a Contributor License Agreement once. You keep the copyright of your work; the CLA gives the maintainer the licence to use it. To sign, comment on this PR with exactly: One signature covers this and every later pull request. Nothing else about this PR changes, and a "CLA" check will appear on your next push. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore conversation resolution for GJC sessions launched through the managed PTY wrapper, without guessing the newest transcript, loosening native transcript roots, or restarting GJC sessions.
Verification
Most recent focused run:
bun test server/managed-gjc-session.test.ts server/managed-gjc-conversation.test.ts server/gjc-sdk.test.ts server/gjc-sdk-generation.test.ts— 186 passed, 0 failed, run in a separate memory-limited environment.Earlier work on this same v0.4.21-based repair passed typecheck/build and a broader focused set. The earlier full fast suite was 9351 passed, 36 skipped, 1 failed:
server/voice.test.ts:229expectedaudio.webm, receivedclip.webm; the failure also reproduced on clean v0.4.21. It has NOT been suppressed or fixed in this PR.Draft / limitations
Authored with AI assistance.