Skip to content

fix(gjc): recover conversations from verified managed sessions - #2552

Draft
Haeminway1 wants to merge 1 commit into
devswha:mainfrom
Haeminway1:fix/managed-gjc-20261031
Draft

Haeminway1 wants to merge 1 commit into
devswha:mainfrom
Haeminway1:fix/managed-gjc-20261031

Conversation

@Haeminway1

Copy link
Copy Markdown
Contributor

Summary

Restore conversation resolution for GJC sessions launched through the managed PTY wrapper, without guessing the newest transcript, loosening native transcript roots, or restarting GJC sessions.

  • Add a separate managed-session ownership verification path covering process birth/boot, executable/runtime identity, pane/session generation, transcript identity and final revalidation.
  • Bind SDK responses to endpoint generation and host incarnation; revalidate authorization after asynchronous operations.
  • Integrate managed conversation/tool-output routing with private, no-store responses and regression fixtures.
  • Keep native lifecycle-extension ownership separate.

Verification

Most recent focused run: bun test server/managed-gjc-session.test.ts server/managed-gjc-conversation.test.ts server/gjc-sdk.test.ts server/gjc-sdk-generation.test.ts — 186 passed, 0 failed, run in a separate memory-limited environment.
Earlier work on this same v0.4.21-based repair passed typecheck/build and a broader focused set. The earlier full fast suite was 9351 passed, 36 skipped, 1 failed: server/voice.test.ts:229 expected audio.webm, received clip.webm; the failure also reproduced on clean v0.4.21. It has NOT been suppressed or fixed in this PR.

Draft / limitations

  • Based on v0.4.21 (6c78047). Upstream main has advanced substantially; compatibility with latest main and the full current CI gate still need review.
  • No production deployment, server replacement, or GJC session restart was performed.
  • Production browser rendering with this patch has not been verified.
  • This is independent of the iOS UI-only work; no design reports, unrelated working-tree edits, private conversation data or generated images are included.

Authored with AI assistance.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devswha

devswha commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Heads-up: this repository now asks every contributor to sign a Contributor License Agreement once. You keep the copyright of your work; the CLA gives the maintainer the licence to use it.

To sign, comment on this PR with exactly:

I have read the CLA Document and I hereby sign the CLA

One signature covers this and every later pull request. Nothing else about this PR changes, and a "CLA" check will appear on your next push.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants