[devswha]

Fixes the items of #1591 that were still open on main. #1805 fixed only the "before the capability snapshot" half of its MEDIUM.

Change

Unconfirmed sends (the MEDIUM). A bridge without submit takes a message as raw input and sends no receipt (HerdrSocket.submit → { ok: true, unconfirmed: true }). Three paths treated that as delivered, although nothing said the pane got the message:

• useComposerSends.composerSend: the composer cleared the draft.
• useComposerSends.actOnPending, Send now on a held copy: removeCopy dropped its recovery row.
• useTerminalSends.sendComposerText, the held queue's Send now: the queue row went.

The text now stays as a pending row in the uncertain state, with the new error code submit_unconfirmed (PendingMessageStore.keepUnconfirmed, or fail(..., uncertain) for the held copy). This is the existing row: "Not confirmed. Check the terminal before sending again." with Copy and Discard saved copy, and no Send now. So it is never sent again from here, and a reload keeps it. The composer box still lets the text go, since the message did leave. No new strings.

Catalog race (LOWs 2 and 5). Composer, ChatView and PaneTerminal each read the pane's command list through cachedPaneCommands. The cache kept only the read started last, so while the terminal's own read was on its way, the box's answered read was shared with nobody. A receipt for a terminal command then found no command and opened no peek.

• An answer is now kept unless a newer read's answer already is. Invalidation and out-of-order answers still never let an older list win.
• paneCommandsNow reads the list at once. PaneTerminal's showSentCommand uses it at the receipt.
• usePaneCommands uses it on its first render, so a chat shown again draws its "Ran in terminal" rows at once instead of as plain bubbles first.

Tests (LOWs 3 and 6).

• src/lib/useComposerSends.test.ts (new): composer send and held-copy Send now, each answered unconfirmed and confirmed.
• src/lib/paneCommandCache.test.ts and src/lib/usePaneCommands.hook.test.ts: the shared answer and the first render.
• scripts/terminal-autoswitch-demo-regression.ts holds the pane's command reads:
  • later: the box's read answered, the terminal's still waiting.
  • all: nothing answered when the message leaves, the 40f6493 order, which nothing covered.
• scripts/skill-menu-cases/claude-terminal.ts gets back the checks feat(chat): hand terminal commands to the terminal lens #1580 dropped: heading order, badge text and fit, and ranking.

Not changed here. A sent frame from another connection for a pane's shared first message still counts as delivery for Send now. That only switches this view, and telling the two apart needs the server's pending-result to say which action dispatched the message, a WS contract change. Filed as #2162.

Design precedent

No new UI. The not-confirmed state is the row Ovis already uses for a send whose delivery it cannot prove (Pi transcript receipts, a dropped connection). The Codex and Claude apps likewise keep a message whose delivery is not confirmed visible with its text, rather than treating it as sent.

Verification

• Unit: the two unconfirmed cases and the first-render case fail with the production files reset to main and pass with the change. The confirmed controls pass on both.
• Browser, bun scripts/terminal-autoswitch-demo-regression.ts:
  • On this branch: 72 PASS, exit 0.
  • On main c739ad0 with only the new script: the later case fails (the menu never gets the list, because the box's answer is not shared).
  • all passes on main (40f6493 fixed it). With 40f6493's ref update removed in a throwaway tree, it fails, so the case guards that fix.
• bun scripts/agent-skill-menu-demo-regression.ts claude-terminal: passes with the restored checks, 42 captures at 1280, 390 and 320 px, light and dark.
• bun run check fast: exit 0. Unit 7910 pass, 0 fail. Typecheck and build pass.
• Reviews of 85cf605:
  • Codex Sol 6.1 fast xhigh: PASS, no actionable findings.
  • omo code reviewer: APPROVE, no CRITICAL, HIGH or MEDIUM. Its LOWs:
    • On a PC without submit, each chat message leaves a "Not confirmed" row until discarded. This is the intended trade-off: matching transcript text to clear them is what the pending store refuses to do.
    • The old held queue's Send now path (sendComposerText) has no unit test of its own. Its submit function is internal to the hook.
    • usePaneCommands reads the cache during render without subscribing to it. This is harmless: the list is what its own read brings.

All captures come from the demo, never a live herdr session. Client-only change: no server, shared/ or remote bundle change.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: devswha/ovis
• Branch: fix/legacy-send-unconfirmed
• File: .coderabbit.yaml
• Commit: 85cf605
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: d92b0bae-13ec-44b9-9e42-2be1752e0d9a

Commits

Reviewing files that changed from the base of the PR and between 99547b0 and 85cf605.

Files selected for processing: 12

• changelog.d/legacy-send-unconfirmed.md
• scripts/skill-menu-cases/claude-terminal.ts
• scripts/terminal-autoswitch-demo-regression.ts
• src/components/PaneTerminal.tsx
• src/lib/paneCommandCache.test.ts
• src/lib/paneCommandCache.ts
• src/lib/pendingMessages.ts
• src/lib/useComposerSends.test.ts
• src/lib/useComposerSends.ts
• src/lib/usePaneCommands.hook.test.ts
• src/lib/usePaneCommands.ts
• src/lib/useTerminalSends.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devswha]

Merging 85cf605: omo-native-code-reviewer and Codex both pass this head. This touches queued input, and both reviewers checked it as such: no send is resent, dropped or delivered to the wrong pane, and the new tests fail on main. The required checks are green, and CodeRabbit did not review this head. Codex's MEDIUM (with a bridge that sends no herdr_lifetime, the unconfirmed copy lives only in page memory, which main also loses) and the LOW notes go to a follow-up issue.