Skip to content

test(gjc): read the started process until herdr shows it with its sessions directory #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devswha merged 1 commit into from
Oct 24, 2026
Merged

test(gjc): read the started process until herdr shows it with its sessions directory #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions server/gjc.contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,13 @@ it("starts the GJC executable found on the server PATH by absolute path", async
const created = await workspaceCreate({ cwd: home, label: "ovis-test-gjc-start" }, socketPath);
workspaces.push(created.workspace.workspace_id);
await startShellAgent("gjc", created.root_pane.pane_id, [sessions]);
const info = await herdrRpc<{ process_info?: { foreground_processes?: { argv?: string[] }[] } }>(
"pane.process_info", { pane_id: created.root_pane.pane_id }, socketPath,
);
expect(info.process_info?.foreground_processes?.find((candidate) => isGjcProcess(candidate.argv ?? []))?.argv?.slice(-1)).toEqual([sessions]);
// read until herdr shows it: one read right after the start can still miss the process it reported in front (#1462)
const gjcArgv = (info: { process_info?: { foreground_processes?: { argv?: string[] }[] } }) =>
info.process_info?.foreground_processes?.find((candidate) => isGjcProcess(candidate.argv ?? []))?.argv;
const info = await until(Date.now() + 10_000,
() => herdrRpc<{ process_info?: { foreground_processes?: { argv?: string[] }[] } }>("pane.process_info", { pane_id: created.root_pane.pane_id }, socketPath),
(read) => gjcArgv(read)?.at(-1) === sessions, "the started gjc, given the sessions directory, in the pane's foreground");
expect(gjcArgv(info)?.slice(-1)).toEqual([sessions]);

process.env["PATH"] = "/nonexistent";
const missing = await workspaceCreate({ cwd: home, label: "ovis-test-gjc-missing" }, socketPath);
Expand Down
Loading