Skip to content

test(conversation): keep the Agy paging and Devin cache tests within their limits under load - #1728

Merged
devswha merged 1 commit into
mainfrom
test/conversation-paging-load
Oct 23, 2026
Merged

devswha merged 1 commit into
mainfrom
test/conversation-paging-load

Conversation

@devswha

@devswha devswha commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Change

Test cost only, no assertion removed:

  • The Agy paging case uses 51 prompts instead of 80, still crossing the 50-prompt page boundary.
  • Devin fixtures insert inside transactions, and the seven-read history-cache case gets a deadline sized to its work instead of bun's 5 s default.

The OpenCode paging tests #1471 also names already got a mitigation in #1653 and are unchanged.

Fixes #1471
Fixes #1556

Validation

  • bun test server/conversation.test.ts server/devin.test.ts: 154 pass. Local per-test times dropped (Devin real-store cases from about 1.3 s to under 130 ms each); the loaded CI host itself was not reproduced.
  • bun run check fast: pass.

Use 51 Agy prompts to cross the 50-prompt page boundary without surplus ledger rows. Keep all append, rewind, cursor and tool-output assertions. OpenCode paging fixtures already disable synchronous writes on main and no longer live in conversation.test.ts.

Batch Devin fixture inserts into single transactions. The real-session fixture previously spent seconds committing individual captured rows; keep the captured snapshot and all assertions unchanged. Give the seven-read history-cache test a 15-second work deadline instead of Bun's five-second default.

Fixes #1471
Fixes #1556
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 2210494 and 9010f07.

📒 Files selected for processing: 2
  • server/conversation.test.ts
  • server/devin.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devswha

devswha commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Merging without a CodeRabbit review: CodeRabbit hit its review limit, so no review ran. The merge pass reviewed it instead. A gate reviewer on a different model than the author's confirmed every assertion is kept. 51 prompts still cross the 50-prompt page boundary. The Devin transactions commit before the reader runs. 154 tests pass, 0 fail. All required checks are green and no review thread is open.

@devswha
devswha merged commit 641aa4f into main Oct 23, 2026
17 checks passed
@devswha
devswha deleted the test/conversation-paging-load branch October 23, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant