Repository navigation
test(qa): align chat, update and machines browser QA scripts with current behaviour - #1286
Merged
Merged
Conversation
…viour - chat-browser-qa: the "Ran git status" row opened while the turn ran stays open through fold and unfold, so click it only when it is not expanded. - update-browser-qa: give the fake v99.0.0 its own changelog section; with changelog.d fragments Unreleased is always empty, and an empty release is not told. - machines-browser-qa: attached files upload in parallel since #864, so both late uploads are in flight (2, not 1); open the folded held rows before pressing Discard while the prompt dock is open (#466). Fixes #1178 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Three browser QA scripts that are not in
scripts/ci-browser.shhad drifted from designed behaviour (#1178). Scripts only; no product change.scripts/chat-browser-qa.ts: the "Ran git status" row opened at the keep-open step stays expanded through fold/unfold, so the laterrow.click()closed it and.work-row-detailnever appeared. It now clicks only whenaria-expanded !== "true".scripts/update-browser-qa.ts: since changelog.d fragments,## [Unreleased]is always empty, so the fake v99.0.0 was cut with an empty section, whichreleaseNotes()drops by design. v99.0.0 now gets its own### Fixedline.scripts/machines-browser-qa.ts: attached files upload in parallel since fix(composer): parallel uploads, paths at the start #864, so both picked files are in flight (expect 2, still all to PC A's/pane/image, PC B's draft kept). The held queue is folded while the prompt dock is open (feat(chat): held messages are quiet rows on the message box's column #466), so the step opens.composer-queue-togglebefore pressing Discard.No changelog fragment: changelog.d/README.md asks for one only for changes users notice.
Not added to
scripts/ci-browser.sh: chat-browser-qa (about 18 s) and update-browser-qa look like cheap candidates, but this PR keeps to the drift fix; machines-browser-qa needs the SSH fixture and a remote bundle, so it stays out.Validation
bun run check run --build bun scripts/chat-browser-qa.ts: all 8 PASS lines.bun run check run bun scripts/update-browser-qa.ts: all 4 PASS lines.machines-browser-qa.tsagainst a freshSSH_TEST_KEEP=1 bun run test:sshfixture (freshbun run build:remotebundle, run underbun run check run): all 4 PASS lines, and the SSH integration itself passed end to end.bun run check fast: exit 0.Fixes #1178
🤖 Generated with Claude Code