Repository navigation
feat(terminal): remove the terminal history scrollbar - #1113
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
The page-wide role=scrollbar check only restated the removal and would trip on any later scrollbar role; the width check proves the gutter is gone. PaneTerminal's viewport id only served the scrollbar's aria-controls. The page-retry wait grows to 3 s so a slow runner does not press twice.
Main removed the terminal history scrollbar (devswha#1113): anchor the jump button to the grid's bottom-right corner without the gutter, drop the scrollbar's aria-controls, page up with the shortcut in the regression step, and update DESIGN.md and the changelog fragment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Why
Owner decision (2026-10-15): delete the terminal history scrollbar outright, with no setting. Paseo and Moshi show no terminal scrollbar either, and on phones the bar reserved a 24px column beside the grid. History stays reachable: the wheel, a finger drag, Mod+Shift+PageUp/PageDown and Find all still scroll herdr's shared history.
Removed
terminal-history-scrollbartrack and thumb inTerminalViewportTools.tsx, with its drag, click and keyboard (arrows, Page Up/Down, Home/End) handlers, its preview state, theviewportIdprop, and thescrollThumb/offsetAtThumbhelpers (and their unit test)..pane-terminal.has-viewport-toolswidth rule, the--terminal-history-guttervariable, and the single-pane header offsets inPaneCanvas.css. The grid now fits the full mount width (the fit addon reads the mount; no cols math subtracted the column).Terminal scrollbacki18n entry (ko/ja/zh), and the scrollbar passages in DESIGN.md, docs/guide.md and the demo log line.Kept
GET /api/pane/scroll) the page keys rely on, Mod+Shift+PageUp/PageDown paging with pending-page accumulation, find highlights and jumps (and Find cancelling queued pages), phone drag and wheel scrolling. Noserver/orshared/changes;pane.scrolland/api/pane/scrollare untouched.Tests
scripts/terminal-viewport-regression.tsnow asserts that no scrollbar is drawn and that the grid spans the whole terminal surface. Steps that used the scrollbar now page with the shortcut. The paging, rebound-shortcut, poll back-off, Find ordering and old-bridge checks are kept.bun run typecheck: exit 0 (also after merging origin/main)bun run test:unit: exit 0 (3645 pass, 0 fail, 8 skip)bun run build: exit 0bun run check run sh -c "bun scripts/terminal-viewport-regression.ts && bun scripts/terminal-pinch-regression.ts && bun scripts/ui-regression.ts": exit 0 (terminal-pinch-regressioncovers one-finger drag scrolling)Supersedes the idea in #945.