[devswha]

Change

Fix the intermittent server/omo.contract.test.ts:52 failure in “labels a running omo pane when herdr supplies no agent kind”.

Root cause and evidence

The fixture waits for its script path in one herdr pane.process_info response, but labelOmoPanes performs a separate fresh process probe. The fixture marker is not a readiness barrier for that probe: a missing matching foreground process or a failed probe leaves the original snapshot's agent undefined. The test asserted the first label sample immediately instead of waiting for the state it describes.

Main run 38555205694 on October 14, 2026 failed after 199.60 ms: expected "omo", received undefined at line 52:77. Five local pre-fix isolated runs passed, including an attempted concurrent unit-suite load, so the failure remained intermittent locally. The CI log and the two independent process probes establish the synchronization gap without guessing which negative-probe branch occurred.

Open PRs #984 and #985 do not touch this test. PR #923 changes custom OmO runtime recognition but leaves this one-shot assertion unchanged, so this is not a duplicate.

Fix

Poll the exact labeled state with a bounded five-second deadline and 50 ms interval. The same original snapshot is retained, so all three existing assertions still prove that herdr supplied no agent kind, the derived snapshot is labeled omo, and the input snapshot is not mutated. No assertion retry, timeout increase, fixed sleep, production change, or changelog entry.

Verification

• Five consecutive isolated contract runs passed on one unchanged source fingerprint: CHECK_WAIT_SECONDS=3600 bun run check run bash -c 'for i in 1 2 3 4 5; do bun test --timeout 15000 ./server/omo.contract.test.ts || exit 1; done'. Report: 23297fbe-e853-45cf-ad71-a4c6990b77e0.
• bun run check fast passed on the same source fingerprint. Generated types, typecheck, build, and unit tests all passed: 3,574 passed, 50 skipped, 0 failed. Report: 19778f35-f21d-4c74-987e-9c48ae6620a9.
• git diff --check passed. Toolchain: Bun 1.4.2, Node 22.23.1, herdr 0.9.3, macOS arm64.

The lane handoff records the root cause, CI timing evidence, diff, full verification log references, and this PR URL at .omo/mass-ulw/2026-10-14/A3.md.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: f639aa35-dc24-4022-90b2-3dc40c4010da

📥 Commits

Reviewing files that changed from the base of the PR and between f979703 and 9616df4.

📒 Files selected for processing: 1

• server/omo.contract.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}