You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
workspace-rows-regression.ts expects a row menu without Move up/Move down since #679 #735
scripts/workspace-rows-regression.ts asserts the workspace row menu is exactly
["Rename workspace", "Rename pane", "New tab", "New worktree", "Open worktree…", "Close workspace"]
Since #679 (17c993f, "a finger reorders workspaces with a long press and a drag") the menu also carries Move up / Move down whenever the workspace has a neighbouring group, which the script's own fixtures (lone, alpha, beta, other beside the resident workspace) always give the other row. The script is run by name only (it is in neither scripts/ci-browser.sh nor scripts/ui-regression.ts), so CI did not see it go stale.
Reproduction on main at 685293e (no other change):
bun run check run --build bun scripts/workspace-rows-regression.ts
AssertionError: a workspace row exposes both explicit rename scopes and workspace operations
+ actual - expected
[ 'Rename workspace', 'Rename pane', 'New tab', 'New worktree', 'Open worktree…',
+ 'Move up',
+ 'Move down',
'Close workspace' ]
at scripts/workspace-rows-regression.ts:207:10
With "Move up", "Move down" added to that expected list the script passes end to end (PASS one row per workspace, its split pane reached from the tab strip, and rename scopes kept apart), so the fix is that one line, plus a decision whether the script should join the browser lane so it cannot go stale again.
Found while verifying the agent-name row menu item (feat/agent-rename), which does not change the move items.
Activity
feat(sidebar): set and show herdr's live agent name from the row menus (