Skip to content

Mirrored terminal (Windows): Enter, Ctrl+C, Esc, arrows and pastes go to the pane as raw pane.send_text, never verified on Windows #257

Closed

Description

@devswha

What happens

A PC whose herdr cannot attach a terminal (Windows) gets a mirrored terminal lens. Everything typed there, both xterm's onData and the key bar, reaches the pane as pane.send_text (server/index.ts:1381-1390; MirrorSession.write at server/mirror.ts:120-123, wired at server/index.ts:509). That includes control bytes:

Only keys frames and the composer's Enter use pane.send_keys (server/index.ts:317-321, server/index.ts:1436-1446).

Nobody has checked whether herdr on Windows turns those bytes into the right key events:

Check on a real Windows PC

Use a separate herdr session, not one in use. In the terminal lens of a mirrored pane, in PowerShell, cmd and an agent TUI (gjc, Claude Code), try:

  • Enter
  • Ctrl+C on a running command
  • Esc
  • arrows and history
  • Tab
  • a multi-line paste
  • Korean IME input

Ideas

  • For a mirrored pane, send the control keys herdr's send_keys knows (Enter, Ctrl+C, Escape, arrows, Tab) through pane.send_keys, and keep printable runs on send_text, in order.
  • Pin what the Windows check finds in a unit test of that mapping.

Found in a read-only review of Windows support. Nothing was run on a Windows PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions