fix: devspace deploy do git pull for cached dependencies

[Andrioden]

What issue type does this pull request address?
/kind bugfix
/kind enhancement

What does this pull request do? Which issues does it resolve?
resolves #2765

Please provide a short message that should be published in the DevSpace release notes
Same as PR title

What else do we need to know?
Alternatively the PR #2709 could be straight up reverted. As reverting would be (i think) functionally the same as this PR. However, it does not read very well. It was not a coincidence that i misunderstood the "git clone" code path of DownloadDependency that i was attempting to fix in my last pr, thought, I am no go developer and are in that sense reading and writing code with a handicap. :P

Testing
As I am not able to write integration tests, i have manually tested a locally built devspace.exe:

• It correctly git clone repos when i delete .dependencies folder
• It correctly reclone git repo when a branch is changed
• It correctly git pull cached dependencies
• It respects the dependency.disablePull flag by not pulling when its true
• It correctly tries to switch the url type (switchURLType(gitPath))

[netlify]

✅ Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	52f0ee4
🔍 Latest deploy log	https://app.netlify.com/sites/devspace-docs/deploys/65c0abe8679c510008d999a5
😎 Deploy Preview	https://deploy-preview-2766--devspace-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[lizardruss]

Thanks for the PR! I like where this is going.

I left some comments, but they may not be clear. More generally, I'd like to call repo.Clone() and repo.Pull() separately, so that it becomes clearer that we skip pulling when a revision has been specified.

I think this would also get rid of the if / else between clone and pull, and make it more like

• clone (if needed)
• pull (if no revision is specified and pulling is not disabled)

This might also make it possible to push the switchURL() logic into repo.Clone & repo.Pull, but I'm ok with duplicating it for logging purposes.

[lizardruss]

I think I might like to see this called after this line when no revision is specified.

This would allow removing the if options.Commit == "" check from Pull, which I think makes it more difficult to understand.

[Andrioden]

Agreed, take a look

[lizardruss]

If pulling is removed from repo.Clone, then we could change this from an else if to an if:

if !source.DisablePull && source.Revision == "" {
  // Pull
}

May need to also handle the error, and attempt to switching the URL, similar to this line.

[Andrioden]

I agree, take a look again.

I am not sure if me messing up the commit history matters? I hope we can squash into the origin repository.

I retested

• It correctly git clone repos when i delete .dependencies folder
• It correctly reclone git repo when a branch is changed
• It correctly git pull cached dependencies
• It respects the dependency.disablePull flag by not pulling when its true

[Andrioden]

Will look at this again later this week

[Andrioden]

ℹ️ Output from newest testing/code, looks good (with considerations within the scope of this PR). Nothing is cloned twice, the amount of pulls are as expected.

14:35:39 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Configuration
14:35:41 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Configuration
14:35:42 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett
14:35:43 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett
14:35:45 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-FellesKonfig
14:35:46 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-FellesKonfig
14:35:48 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett
14:35:50 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Felleslogg
14:35:51 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Felleslogg
14:35:52 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett
14:35:58 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Personvern
14:35:59 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Personvern
14:36:01 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett
14:36:07 debug Cloned https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-STS
14:36:08 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-STS
14:36:09 debug Pulled https://nhnfelles@dev.azure.com/nhnfelles/Helsenorge/_git/HN-Oppsett

[Andrioden]

I believe this is ready for merge @lizardruss (just remember to Squash)

[lizardruss]

Thanks for the changes! LGTM! Will run tests and squash the commits when merging.

[Andrioden]

@lizardruss - Fixed lint errors, at least i think i have, i was not able to reproduce them locally, and the workflow here is not run until you trigger them.

[Andrioden]

@lizardruss - Any chance this could be merged?