fix: Imported variables are not used in other variables#2432
Merged
FabianKramm merged 4 commits intodevspace-sh:mainfrom Nov 21, 2022
Merged
fix: Imported variables are not used in other variables#2432FabianKramm merged 4 commits intodevspace-sh:mainfrom
FabianKramm merged 4 commits intodevspace-sh:mainfrom
Conversation
pratikjagrut
requested review from
FabianKramm and
LukasGentele
as code owners
lizardruss
previously requested changes
Nov 17, 2022
Collaborator
lizardruss
left a comment
lizardruss
left a comment
There was a problem hiding this comment.
There could be unexpected behavior with the current implementation. I'll ask for a second opinion as well.
pratikjagrut
force-pushed
the
import.vars
branch
from
bfe49b5 to
58ffb79
Compare
pratikjagrut
force-pushed
the
import.vars
branch
from
58ffb79 to
7202a0f
Compare
FabianKramm
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2408
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace was not using imported variables in defining another variable in main devspace.yaml