fix: correctly compare semver according to spec 2.0.0 #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKramm
approved these changes
Aug 26, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@ciidyr thanks for the PR! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)According to the latest stable semver spec, devspace is currently not correctly comparing semver versions.
We noticed this when a constraint we had set (
>= 6.0.0-beta.4did not allow the usage of6.0.1-beta.0). According to Item 11 of the spec (https://semver.org/spec/v2.0.0.html#spec-item-11), this should have worked.I tracked this down to a constraint in the
prereleaseCheckfunction, that only allowed pre-release versions of the same base segments to be correctly compared. Removing this check still passes all tests but now correctly follows the spec in that regard.I also removed a duplicate test from the suite.
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace incorrectly compared semantic versions.
What else do we need to know?