Skip to content

Resolve untracked docker-compose.e2e.yml leftover artifact #25

Description

@devops-thiago

Background

docker-compose.e2e.yml is untracked (a leftover from the workshop branch workflow). It overrides a java-rag-app service with env vars MODEL_PROVIDER=openai, MODEL_OPENAI_API_KEY, MODEL_OPENAI_BASE_URL, MODEL_OPENAI_MODEL_NAME, MODEL_OPENAI_TIMEOUT_SECONDS, and JAVA_OPTS.

Impact

  • It is a stray file that can be accidentally committed or silently shadow the main stack (docker compose -f docker-compose.e2e.yml overrides java-rag-app).
  • The env var names are inconsistent with the actual model.openai.* properties. They work only via Spring relaxed binding, and MODEL_PROVIDER is not a property of this application at all.
  • The E2E run depends on an untracked file, so it is not reproducible by other contributors.

How to reproduce

  1. docker compose -f docker-compose.e2e.yml up — attempts to build/run java-rag-app with the overrides; behavior depends on a local .env.

Where the fix should land

Decide the file's fate and act:

  • Keep: commit it, rename to something self-describing (e.g. docker-compose.e2e.ollama-cloud.yml), align env vars with the model.openai.* property names in application-docker.yml, and document the E2E invocation in the README.
  • Remove: delete it and document the E2E path in the README instead.

Files touched

  • docker-compose.e2e.yml (commit/update or delete)
  • README.md (documentation)
  • src/main/resources/application-docker.yml (only if env var names are aligned)

Acceptance criteria

  • The file is either committed with accurate env vars and docs, or removed from the workspace.
  • git status is clean of this stray file.
  • If kept: the documented E2E invocation works against a cloud model.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions