Enable cross-platform testing with dotnet test on Linux - #684
Merged
Conversation
Member
|
🧪 Details on Ubuntu 24.04.3 LTS🧪 Details on Microsoft Windows 10.0.26100from dotnet-retest v1.0.0 on .NET 10.0.1 with 💜 by @devlooped |
Copilot
AI
changed the title
[WIP] Enable cross-platform testing with dotnet test on Linux
Enable cross-platform testing with dotnet test on Linux
Jan 14, 2026
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
…ility Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
kzu
force-pushed
the
copilot/enable-cross-platform-testing
branch
from
January 15, 2026 03:26
42fc065 to
24b21e4
Compare
Member
|
@copilot revert to a single |
…tu-latest Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Refactored to use a single |
Member
|
@copilot can you use |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Member
|
@copilot see if you can fix the following failing tests under windows now: ❌ NuGetizer.CreatePackageTests.when_creating_package_with_content_file_build_action_then_adds_as_content_file
❌ NuGetizer.CreatePackageTests.when_creating_package_with_content_file_then_adds_as_content_file
❌ NuGetizer.given_a_custom_build_project.when_packing_then_can_include_content
❌ NuGetizer.given_a_framework_library.when_getting_package_contents_then_includes_framework_references_by_default
❌ NuGetizer.given_a_framework_library.when_include_outputs_in_package_is_false_then_does_not_include_main_assembly
❌ NuGetizer.given_a_library_with_content.content_with_package_path_is_included_even_with_pack_content_false
❌ NuGetizer.given_a_library_with_content.none_copy_include_false_is_not_included
❌ NuGetizer.given_a_library_with_project_reference.when_getting_package_contents_then_retrieves_main_assembly_transitively
❌ NuGetizer.given_a_library_with_project_reference.when_getting_package_contents_then_retrieves_symbols_transitively
❌ NuGetizer.given_a_library_with_project_reference.when_include_in_package_false_then_does_not_include_referenced_project_outputs
❌ NuGetizer.given_a_library_with_project_reference.when_include_outputs_in_package_false_then_can_include_referenced_project_outputs
❌ NuGetizer.given_a_library_with_project_reference.when_include_outputs_in_package_false_then_can_include_referenced_projects_outputs
❌ NuGetizer.given_a_localized_library.when_getting_package_contents_then_contains_localized_resources
❌ NuGetizer.given_transitive_projects.when_pack_no_build_then_succeeds
|
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Fixed in 9f9e9ba:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot Remaining failure: [34 ms] |
Member
|
@copilot See if we should use the MSBuild locator as-is without our customization with ThisAssembly.Project.MSBuildBinPath. Read the docs at https://learn.microsoft.com/en-us/visualstudio/msbuild/find-and-use-msbuild-versions?view=visualstudio#use-microsoftbuildlocator to see. |
…Path Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Updated in 4fc72d1 to use Per the docs, Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot that's not working. let's revert that and try conditionally building tests for net472 on windows and net10.0 otherwise. that should bring back the working approach that's currently on main (before any of these commits) |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Implemented in 5bf1ec8. Reverted the csproj changes:
ModuleInitializer.cs:
Also removed the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot the condition shoudl be on TargetFramework (singular) not TargetFrameworks (since we're not really multi-targeting, only one) |
…ional OS targeting Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Fixed in a2fec97. Changed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot seems like we need some conditional compilation for net472 for RuntimeAttributeFact: D:\a\nugetizer\nugetizer\src\NuGetizer.Tests\Utilities\RuntimeFactAttribute.cs(37,72): error CS0117: 'RuntimeInformation' does not contain a definition for 'RuntimeIdentifier' [D:\a\nugetizer\nugetizer\src\NuGetizer.Tests\NuGetizer.Tests.csproj] |
…able in net472) Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Fixed in 1aee092. Added Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot progress!! it seems the only remaining couple bugs are path-related: NuGetizer.InlineProjectTests.when_package_icon_relative_folder_default_then_packs_icon [FAIL] |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
Fixed in a8161c8. Reverted these tests to their original Windows path format (using backslashes in MSBuild project XML) and marked them with
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
kzu
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net472on Windows,net10.0on LinuxTargetFramework(singular) with OS condition since only one framework is used at a timeModuleInitializer.cswith conditional compilation:net472(ThisAssembly.Project.MSBuildBinPath)net10.0(Path.GetTempPath(), RuntimeInformation)Builder.csto usePath.Combineinstead of hardcoded backslashesRuntimeFactAttributeandRuntimeTheoryAttributefor platform-specific test skipping#if !NET472forRuntimeIdentifierproperty (not available in .NET Framework)RuntimeFact("Windows")/RuntimeTheory("Windows").Replace('\\', '/'))build.ymlto use strategy matrix withwindows-latestandubuntu-latestdotnet test(243 tests pass, 66 skipped for Windows-only)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.