Skip to content

fix: show download progress on Windows PowerShell - #13

Merged
kzu merged 1 commit into
mainfrom
dev/win-progress
Aug 25, 2026
Merged

fix: show download progress on Windows PowerShell#13
kzu merged 1 commit into
mainfrom
dev/win-progress

Conversation

@kzu

@kzu kzu commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

PowerShell 7 on Windows pipes native stderr, so Console.IsErrorRedirected is true in an interactive terminal and ndnx skipped the download bar. WSL/bash attaches the TTY, which is why it worked there.

On Windows, write progress to CONOUT$ (the screen buffer) instead of the redirected stderr handle. Also drain stdout and stderr concurrently when tests launch ndnx, so a busy stderr pipe cannot deadlock CI.

Test plan

  • App_writes_download_progress_to_host_Progress
  • Existing known/unknown/redirected progress tests

@kzu kzu added the bug Something isn't working label Aug 25, 2026
@kzu
kzu enabled auto-merge (rebase) August 25, 2026 06:27
@kzu

kzu commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

182 passed 182 passed

🧪 Details on Ubuntu 24.04.4 LTS

from retest v1.1.0 on .NET 10.0.11 with 💜 by @devlooped

@kzu
kzu merged commit 3db6fef into main Aug 25, 2026
4 checks passed
@kzu
kzu deleted the dev/win-progress branch August 25, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant