Show download progress for large native nupkgs - #10
Merged
Merged
Conversation
When the console is not redirected, HTTP nupkg copies render a byte bar from catalog packageSize or Content-Length. If no total is known, show a spinner plus downloading. Catalog lookup is fail-open and never skips the download. Progress is written to stderr so the child tool still owns stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large native hops (for example
azxonlinux-*, 200+ MB) previously sat silent while the nupkg copied into the cache.When the console is not redirected, HTTP nupkg downloads now render live progress on stderr:
packageSize, elseContent-LengthdownloadingTest plan
DownloadProgressTestscover bar vs spinner framesPackageFeedTestsdrive the shippedTryDownloadAsyncpath: known size, unknown size, redirected/off, catalog 404 still downloadsdotnet test src/Tests/Tests.csproj --nologotwice (173 passed)