Merged
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
changed the title
Contributor
Author
|
I've put WIP as I'm currently testing my changes |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Contributor
Author
|
I have tested the sample devfile (1.18) with the current 1.2.0 version as parent and I was able to build it. |
thepetk
changed the title
rm3l
approved these changes
Nov 6, 2023
kim-tsao
approved these changes
Nov 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR creates two new versions for
gostack:version: 1.2.0: In order to support backwards compatibility with samples the1.2.0is a new version of1.1.0but it is using the golang version 1.19 instead of 1.18.version: 2.2.0: This is a new version of2.1.0which is using the golang version 1.19 instead of1.18.Additionally, this PR adds the
Deprecatedlabel to the following stack versions as they are using go version 1.18 which is no longer supported. The new default version is the1.2.0.Which issue(s) this PR fixes:
fixes devfile/api#1300
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: