Update contributing guide for sample multiple versions#199
Merged
maysunfaisal merged 5 commits intodevfile:mainfrom Sep 22, 2023
Merged
Update contributing guide for sample multiple versions#199maysunfaisal merged 5 commits intodevfile:mainfrom
maysunfaisal merged 5 commits intodevfile:mainfrom
Conversation
2 tasks
|
/test remaining-required |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
feature/update_contributing_doc
branch
from
5a68f4b to
6f3a824
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
maysunfaisal
approved these changes
Sep 21, 2023
Member
|
@thepetk needs rebase i think? |
Contributor
Author
@maysunfaisal done :) |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
maysunfaisal
approved these changes
Sep 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
After the merge of the PR for the support of branches per version of devfile sample, it would be useful to add more information about this to the contributing guide.
Which issue(s) this PR fixes:
Fixes devfile/api#1209
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: