Skip to content

feat: Support R2 URLs with jurisdictions - #757

Merged
kylebarron merged 3 commits into
developmentseed:mainfrom
Kharacternyk:main
Aug 21, 2026
Merged

feat: Support R2 URLs with jurisdictions#757
kylebarron merged 3 commits into
developmentseed:mainfrom
Kharacternyk:main

Conversation

@Kharacternyk

@Kharacternyk Kharacternyk commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@ds-release-bot ds-release-bot Bot added the feat label Jul 23, 2026
@Kharacternyk

Kharacternyk commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I don't understand from the GitHub action logs which of my changes are triggering the pre-commit failure

@kylebarron

kylebarron commented Jul 24, 2026

Copy link
Copy Markdown
Member

Thanks for the PR.

In regards to the pre-commit error, I think the issue is probably that it's not pinned to a specific version of ruff, and that a new version of ruff added that lint.

Separately, the code you're touching in this PR, parse_url is vendored from upstream https://github.com/apache/arrow-rs-object-store. For maintenance reasons, I don't want our copy to diverge from upstream.

So if you could make a PR to upstream object-store, that would be great, and once that is merged, then we can merge this here as well.

@Kharacternyk

Kharacternyk commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi @kylebarron, this has been merged upstream: apache/arrow-rs-object-store#815

@kylebarron

kylebarron commented Aug 20, 2026

Copy link
Copy Markdown
Member

great thanks, if you could merge in main, that should fix the CI

@kylebarron kylebarron mentioned this pull request Aug 21, 2026
Open
3 of 5 tasks
@Kharacternyk

Kharacternyk commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Yep, all green now

kylebarron
kylebarron approved these changes Aug 21, 2026
View reviewed changes

@kylebarron kylebarron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kylebarron
kylebarron merged commit 30051a3 into developmentseed:main Aug 21, 2026
9 checks passed
@kylebarron kylebarron mentioned this pull request Oct 15, 2026
Merged
kylebarron added a commit that referenced this pull request Oct 15, 2026
@kylebarron @claude
chore(pyo3-object_store): Bump to pyo3 0.30 and prepare 0.13 release (#…
c8efd78 
…797)

* chore(pyo3-object_store): Bump to pyo3 0.30 and prepare 0.13 release

Also bumps pyo3-async-runtimes to 0.30, and adds the unreleased R2
jurisdiction support (#757) to the changelog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: Build obstore against pyo3-object_store 0.12 from main via git

The in-repo pyo3-object_store now needs pyo3 0.30, but obstore is still
on pyo3 0.29 (pyo3-arrow and pyo3-file have no 0.30 release yet), so the
path dependency no longer resolves. Pin obstore to pyo3-object_store at
the current main rev until obstore moves to 0.30.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees

No one assigned

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kharacternyk @kylebarron