Skip to content

Friendly microbundle-specific resolve errors #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 3 commits into from
Sep 28, 2020
Merged

Friendly microbundle-specific resolve errors #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
459becd
[wip] Friendly microbundle-specific resolve errors
developit Jul 21, 2020
bb3408a
lint fixes
developit Sep 28, 2020
fcd5265
Create angry-goats-knock.md
developit Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-goats-knock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"microbundle": patch
---

Add friendly microbundle-specific errors when modules can't be resolved.
17 changes: 17 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,26 @@ function createConfig(options, entry, format, writeMeta) {
}
return externalTest(id);
},

onwarn(warning, warn) {
// https://github.com/rollup/rollup/blob/0fa9758cb7b1976537ae0875d085669e3a21e918/src/utils/error.ts#L324
if (warning.code === 'UNRESOLVED_IMPORT') {
stdout(
`Failed to resolve the module ${warning.source} imported by ${warning.importer}` +
`\nIs the module installed? Note:` +
`\n ↳ to inline a module into your bundle, install it to "devDependencies".` +
`\n ↳ to depend on a module via import/require, install it to "dependencies".`,
);
return;
}

warn(warning);
},

treeshake: {
propertyReadSideEffects: false,
},

plugins: []
.concat(
postcss({
Expand Down