Skip to content

refactor: remove unused fileFacts fixture helper - #87

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/remove-the-unused-filefacts-fixture-surface--bfaf83a2
Oct 29, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/remove-the-unused-filefacts-fixture-surface--bfaf83a2

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What

fileFacts (src/doctor/harness.ts:146) had no consumers anywhere in the
repo — no import, call, test or doc reference — so its existence only
implied file-hygiene coverage nothing exercised. Remove the helper and
the statSync import it alone used. All other harness exports are
unchanged; their consumers (commands/doctor.test.ts,
doctor/stub-server.test.ts) are untouched.

Acceptance

  • Repo-wide grep for fileFacts (and file_facts / file-facts variants) returns zero hits
  • src/doctor/harness.ts imports only existsSync, readFileSync, unlinkSync from node:fs — no orphaned statSync; biome check on the file exits clean
  • bun test src/commands/doctor.test.ts src/doctor/stub-server.test.ts passes — the two remaining harness consumers still compile and pass against the unchanged exports
  • The diff to src/doctor/harness.ts is exactly the removed fileFacts block plus the narrowed node:fs import; every other export identical

Changes

  • src/doctor/harness.ts (edit) — Delete the unused exported helper fileFacts and its docblock (lines 145-152): a repo-wide grep found zero consumers — no import, call, test or doc reference. Also drop statSync from the line-1 node:fs named import (it is used only inside fileFacts), leaving import { existsSync, readFileSync, unlinkSync } from "node:fs";. Every other export (KEY, ROUTER, FOREIGN_CREDENTIAL, TIERS, sampleConfig, versionProc, FakeClaudeOptions, FakeClaudeCall, fakeClaudeProc) stays byte-for-byte unchanged — doctor.test.ts and stub-server.test.ts import them as-is.

Verification

./bin/check passed (exit 0) in 40s.


🤖 Opened by developerz.ai for task tsk_bfaf83a2f017ef00a82ececd10d1569a on developerz-ai/claudes.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model glm-5.3-flash on api.z.ai via native, funded by account_key
Ran on box sebastian-3
Cost ~$0.04 for 255.2k in / 16.8k out (estimate: list price x reported tokens, cached input at its cached rate)
Run timeline run_f2359bfd6d1e48b6b7a9117defd480bb
Part 1/1 of plan rtk_777bec2d44254db6ae1e0231bdba2acc

fileFacts (src/doctor/harness.ts:146) had no consumers anywhere in the
repo — no import, call, test or doc reference — so its existence only
implied file-hygiene coverage nothing exercised. Remove the helper and
the statSync import it alone used. All other harness exports are
unchanged; their consumers (commands/doctor.test.ts,
doctor/stub-server.test.ts) are untouched.

Dz-Task-Id: tsk_bfaf83a2f017ef00a82ececd10d1569a
@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:glm-5.3-flash developerz.ai: model that wrote this bot PR. dz/provider:api.z.ai developerz.ai: provider that served this bot PR. labels Oct 29, 2026
@developerz-ai

developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 35s wall clock · gpt-6.1-sol via router · 1 model call(s) · 65 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 0 finding(s).

[bot] completed: Removes the unused fileFacts fixture and its statSync import without changing other harness exports. No concrete defects found in the supplied diff.

  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-reviewer-1 — 15.2k in / 65 out over 1 call; cost unknown: no price on record for router/gpt-6.1-sol.

@developerz-ai
developerz-ai Bot merged commit 3ecc335 into main Oct 29, 2026
5 checks passed
@sebyx07
sebyx07 deleted the dz/remove-the-unused-filefacts-fixture-surface--bfaf83a2 branch October 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:glm-5.3-flash developerz.ai: model that wrote this bot PR. dz/provider:api.z.ai developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants