Repository navigation
refactor: remove unused fileFacts fixture helper - #87
developerz-ai[bot] merged 1 commit into
Conversation
fileFacts (src/doctor/harness.ts:146) had no consumers anywhere in the repo — no import, call, test or doc reference — so its existence only implied file-hygiene coverage nothing exercised. Remove the helper and the statSync import it alone used. All other harness exports are unchanged; their consumers (commands/doctor.test.ts, doctor/stub-server.test.ts) are untouched. Dz-Task-Id: tsk_bfaf83a2f017ef00a82ececd10d1569a
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 35s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 1 file(s), 0 finding(s).
[bot] completed: Removes the unused fileFacts fixture and its statSync import without changing other harness exports. No concrete defects found in the supplied diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-reviewer-1 — 15.2k in / 65 out over 1 call; cost unknown: no price on record for router/gpt-6.1-sol.
What
fileFacts (src/doctor/harness.ts:146) had no consumers anywhere in the
repo — no import, call, test or doc reference — so its existence only
implied file-hygiene coverage nothing exercised. Remove the helper and
the statSync import it alone used. All other harness exports are
unchanged; their consumers (commands/doctor.test.ts,
doctor/stub-server.test.ts) are untouched.
Acceptance
Changes
src/doctor/harness.ts(edit) — Delete the unused exported helper fileFacts and its docblock (lines 145-152): a repo-wide grep found zero consumers — no import, call, test or doc reference. Also drop statSync from the line-1 node:fs named import (it is used only inside fileFacts), leavingimport { existsSync, readFileSync, unlinkSync } from "node:fs";. Every other export (KEY, ROUTER, FOREIGN_CREDENTIAL, TIERS, sampleConfig, versionProc, FakeClaudeOptions, FakeClaudeCall, fakeClaudeProc) stays byte-for-byte unchanged — doctor.test.ts and stub-server.test.ts import them as-is.Verification
./bin/checkpassed (exit 0) in 40s.🤖 Opened by developerz.ai for task
tsk_bfaf83a2f017ef00a82ececd10d1569aon developerz-ai/claudes.Raised automatically by the
raw_task_triagelane.