Skip to content

test: consolidate fake router response fixtures - #83

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/consolidate-shared-fake-router-response-fixtures--663ef371
Oct 29, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/consolidate-shared-fake-router-response-fixtures--663ef371

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Acceptance

  • Login harness, client router tests, doctor router tests, launch harness and local/generated e2e healthy responders delegate construction to the canonical fixture.
  • Health and models body/status overrides remain independently expressible; client Response overrides preserve identity, streams, cancellation behavior and precedence.
  • Doctor tests retain four-model IDS and callback rejection scenarios; login/client retain original three-model defaults and all existing assertions.
  • Launch harness and e2e healthy responders still return fresh HTTP 200 health payloads with version 1.4.2 regardless of fetch URL; no unused healthyFetch export remains.
  • Fixture tests pin defaults, fresh Responses, overrides and unexpected-path refusal; scoped tests and final bin/check pass.

Changes

  • src/test-support/fixtures.ts (edit) — Add framework-free routerResponse(url, options?) and RouterResponseOptions for health/models status, raw body and exact Response overrides. Centralize version 1.4.2 and existing three-model defaults; preserve nullish defaults and Response identity, never clone streams. Reject unknown endpoint paths rather than silently serving models. Keep KEY/ROUTER unchanged.
  • src/test-support/fixtures.test.ts (edit) — Keep schema assertions; add responder tests for default payloads, fresh independently readable default Responses, both endpoints' status/raw-body overrides including empty bodies, exact Response override identity/precedence, and unknown-path refusal. Pin health-only usage to version 1.4.2.
  • src/commands/login-harness.ts (edit) — Replace duplicated response construction at lines 23-38 with routerResponse. Preserve exported stubFetch/StubOptions signatures, failWith precedence and harness fetch-call recording so existing login callers require no changes.
  • src/router/client.test.ts (edit) — Replace local response construction/options duplication with shared routerResponse/options; retain Call recording and failWith handling. Preserve every assertion, especially exact Response overrides for streamed errors, caps and cancellation; do not clone or inspect supplied Responses eagerly.
  • src/doctor/checks/router.test.ts (edit) — Delegate default responses to routerResponse while retaining health/models callbacks and authorization recording. Pass existing four IDS as explicit modelsBody override so pinned-tier and four-model assertions remain unchanged. Preserve callback rejections and version-withholding scenarios.
  • src/launch/run-harness.ts (edit) — Replace healthyFetch literal response with routerResponse called with the fixed health URL, preserving health responses regardless of supplied fetch URL. Remove its export (no external readers found), keep it used by drive, and leave other harness behavior unchanged.
  • src/launch/run.e2e.test.ts (edit) — Use routerResponse for local healthyFetch with fixed health URL, preserving health-only behavior. Replace generated launcher.mjs inline healthy responder at lines 325-331 with an absolute file-URL fixture import and same health-only call. Keep spawn, cleanup, signal, settings-lifetime and leak assertions intact.

Verification

./bin/check passed (exit 0) in 1m 09s.

Notes

Premises of the request the team disproved:

  • Responders differ in model defaults: src/doctor/checks/router.test.ts:8,32 serves four IDs including 5-5 tiers, whereas src/commands/login-harness.ts:30-35 and src/router/client.test.ts:47-52 serve three older-tier IDs. Preserve doctor defaults explicitly.
  • (from a dropped noWork claim) The submitted plan is work to perform, not a no-work refusal.

🤖 Opened by developerz.ai for task tsk_663ef371b7996d99086baa1952bc042c on developerz-ai/claudes.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model gpt-6.1-sol on router.ai.developerz.ai via native, funded by account_key
Ran on box hv-dedicated-6
Cost unknown: no list price on record for gpt-6.1-sol on router.ai.developerz.ai
Run timeline run_55f38fef2422433693a7732b99fb542b
Part 1/1 of plan rtk_d02fd0218a4b4254afa2868941743092

Dz-Task-Id: tsk_663ef371b7996d99086baa1952bc042c
@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:gpt-6.1-sol developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR. labels Oct 29, 2026
@developerz-ai

developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⏱ 1m 00s wall clock · gpt-6.1-sol via router · 2 model call(s) · 230 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 8 file(s), 0 finding(s).

Completed [bot]: Consolidates router response fixtures while preserving endpoint defaults, exact Response identity, doctor model IDs and health-only launch responders. No blocking defects found in the supplied diff.

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-6 — 92.7k in / 230 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.

@developerz-ai
developerz-ai Bot merged commit 3fb7d56 into main Oct 29, 2026
5 checks passed
@sebyx07
sebyx07 deleted the dz/consolidate-shared-fake-router-response-fixtures--663ef371 branch October 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:gpt-6.1-sol developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants