Repository navigation
test: consolidate fake router response fixtures - #83
Merged
developerz-ai[bot] merged 1 commit intoOct 29, 2026
Merged
developerz-ai[bot] merged 1 commit into
developerz-ai[bot] merged 1 commit into
Conversation
Dz-Task-Id: tsk_663ef371b7996d99086baa1952bc042c
Contributor
Author
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 1m 00s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
Contributor
Author
There was a problem hiding this comment.
Review summary — 8 file(s), 0 finding(s).
Completed [bot]: Consolidates router response fixtures while preserving endpoint defaults, exact Response identity, doctor model IDs and health-only launch responders. No blocking defects found in the supplied diff.
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-6 — 92.7k in / 230 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.
sebyx07
deleted the
dz/consolidate-shared-fake-router-response-fixtures--663ef371
branch
October 29, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance
Changes
src/test-support/fixtures.ts(edit) — Add framework-free routerResponse(url, options?) and RouterResponseOptions for health/models status, raw body and exact Response overrides. Centralize version 1.4.2 and existing three-model defaults; preserve nullish defaults and Response identity, never clone streams. Reject unknown endpoint paths rather than silently serving models. Keep KEY/ROUTER unchanged.src/test-support/fixtures.test.ts(edit) — Keep schema assertions; add responder tests for default payloads, fresh independently readable default Responses, both endpoints' status/raw-body overrides including empty bodies, exact Response override identity/precedence, and unknown-path refusal. Pin health-only usage to version 1.4.2.src/commands/login-harness.ts(edit) — Replace duplicated response construction at lines 23-38 with routerResponse. Preserve exported stubFetch/StubOptions signatures, failWith precedence and harness fetch-call recording so existing login callers require no changes.src/router/client.test.ts(edit) — Replace local response construction/options duplication with shared routerResponse/options; retain Call recording and failWith handling. Preserve every assertion, especially exact Response overrides for streamed errors, caps and cancellation; do not clone or inspect supplied Responses eagerly.src/doctor/checks/router.test.ts(edit) — Delegate default responses to routerResponse while retaining health/models callbacks and authorization recording. Pass existing four IDS as explicit modelsBody override so pinned-tier and four-model assertions remain unchanged. Preserve callback rejections and version-withholding scenarios.src/launch/run-harness.ts(edit) — Replace healthyFetch literal response with routerResponse called with the fixed health URL, preserving health responses regardless of supplied fetch URL. Remove its export (no external readers found), keep it used by drive, and leave other harness behavior unchanged.src/launch/run.e2e.test.ts(edit) — Use routerResponse for local healthyFetch with fixed health URL, preserving health-only behavior. Replace generated launcher.mjs inline healthy responder at lines 325-331 with an absolute file-URL fixture import and same health-only call. Keep spawn, cleanup, signal, settings-lifetime and leak assertions intact.Verification
./bin/checkpassed (exit 0) in 1m 09s.Notes
Premises of the request the team disproved:
🤖 Opened by developerz.ai for task
tsk_663ef371b7996d99086baa1952bc042con developerz-ai/claudes.Raised automatically by the
raw_task_triagelane.