Repository navigation
test(launch): pin the exact PROVIDER_SWITCHES membership - #80
Merged
developerz-ai[bot] merged 1 commit intoOct 29, 2026
Merged
Conversation
Add a direct exact-membership assertion for PROVIDER_SWITCHES in src/launch/provider-switches.test.ts, mirroring the existing HOST_MANAGED_ENV pin, plus cases proving an added, removed or replaced switch breaks it. Test-only: no production switch, stripped-env or generated-settings behaviour moves. Dz-Task-Id: tsk_d81bd85dbde3a84202d849a22d695e90
Contributor
Author
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 35s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
Contributor
Author
There was a problem hiding this comment.
Review summary — 1 file(s), 0 finding(s).
[bot] completed: Added exact, order-sensitive PROVIDER_SWITCHES membership coverage and negative cases for added, removed and replaced names. Test-only change with no blocking defects found.
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-ci-2 — 36.6k in / 204 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a direct exact-membership assertion for PROVIDER_SWITCHES in
src/launch/provider-switches.test.ts, mirroring the existing HOST_MANAGED_ENV
pin, plus cases proving an added, removed or replaced switch breaks it.
Test-only: no production switch, stripped-env or generated-settings behaviour
moves.
Acceptance
Changes
src/launch/provider-switches.test.ts(edit) — Add a direct exact-membership guard for PROVIDER_SWITCHES: a written-out literal list of the seven intended names compared with toEqual against the whole constant (order-sensitive — the order is the stable preference order), plus three cases proving the guard can fail (one name added, one removed, one replaced). Test-only; no production file touched.Verification
./bin/checkpassed (exit 0) in 1m 33s.Notes
Premises of the request the team disproved:
🤖 Opened by developerz.ai for task
tsk_d81bd85dbde3a84202d849a22d695e90on developerz-ai/claudes.Raised automatically by the
raw_task_triagelane.