Skip to content

test(launch): pin the exact PROVIDER_SWITCHES membership - #80

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/pin-provider-switch-membership--d81bd85d
Oct 29, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/pin-provider-switch-membership--d81bd85d

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What

Add a direct exact-membership assertion for PROVIDER_SWITCHES in
src/launch/provider-switches.test.ts, mirroring the existing HOST_MANAGED_ENV
pin, plus cases proving an added, removed or replaced switch breaks it.

Test-only: no production switch, stripped-env or generated-settings behaviour
moves.

Acceptance

  • src/launch/provider-switches.test.ts asserts the whole PROVIDER_SWITCHES array with toEqual against a written-out list of the seven intended names, so an added, removed or replaced switch fails the test.
  • The same file proves the guard can fail: an added, a removed and a replaced variant of the list each make the membership assertion throw.
  • bun test src/launch/provider-switches.test.ts passes, and the existing provider-switch behaviour tests (firstSetProviderSwitch, firstReroutingUseToggle, firstUnknownReroutingUseToggle, firstHostManagedEnv, isTruthyToggle) are intact.
  • No production file is modified — src/launch/provider-switches.ts, src/launch/env.ts and src/launch/settings.ts are untouched, so the switch set, the stripped child env and the generated settings are unchanged.

Changes

  • src/launch/provider-switches.test.ts (edit) — Add a direct exact-membership guard for PROVIDER_SWITCHES: a written-out literal list of the seven intended names compared with toEqual against the whole constant (order-sensitive — the order is the stable preference order), plus three cases proving the guard can fail (one name added, one removed, one replaced). Test-only; no production file touched.

Verification

./bin/check passed (exit 0) in 1m 33s.

Notes

Premises of the request the team disproved:

  • The request reads as if no test catches a provider-switch membership change; one already does, incidentally: src/launch/settings.test.ts:61-96 compares the ENTIRE generated settings env with toEqual against a literal that lists all seven switch names (lines 74-80), so an added, removed or replaced switch already fails that test, and src/launch/env.test.ts:62-64 fails on a removal. The re [trimmed]

🤖 Opened by developerz.ai for task tsk_d81bd85dbde3a84202d849a22d695e90 on developerz-ai/claudes.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model MiniMax-M3 on api.minimax.io via native, funded by account_key
Ran on box hv-dedicated-ci-2
Cost ~$0.14 for 1M in / 35.3k out (estimate: list price x reported tokens, cached input at its cached rate)
Run timeline run_006d5907a3f24be88d1f3df85345f3d7
Part 1/1 of plan rtk_c254e3518d0d4e6daa958e719d655a12

Add a direct exact-membership assertion for PROVIDER_SWITCHES in
src/launch/provider-switches.test.ts, mirroring the existing HOST_MANAGED_ENV
pin, plus cases proving an added, removed or replaced switch breaks it.

Test-only: no production switch, stripped-env or generated-settings behaviour
moves.

Dz-Task-Id: tsk_d81bd85dbde3a84202d849a22d695e90
@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR. labels Oct 29, 2026
@developerz-ai

developerz-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⏱ 35s wall clock · gpt-6.1-sol via router · 2 model call(s) · 204 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 0 finding(s).

[bot] completed: Added exact, order-sensitive PROVIDER_SWITCHES membership coverage and negative cases for added, removed and replaced names. Test-only change with no blocking defects found.

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-ci-2 — 36.6k in / 204 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.

@developerz-ai
developerz-ai Bot merged commit f3f04a6 into main Oct 29, 2026
5 checks passed
@sebyx07
sebyx07 deleted the dz/pin-provider-switch-membership--d81bd85d branch October 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants