Skip to content

wp/6.5: Serialize npm publishing runs per WordPress version without canceling them - #899

Open
desrosj wants to merge 1 commit into
fix-actions-wp-6.5-npm-publish-dry-runfrom
fix-actions-wp-6.5-npm-publish-concurrency
Open

desrosj wants to merge 1 commit into
fix-actions-wp-6.5-npm-publish-dry-runfrom
fix-actions-wp-6.5-npm-publish-concurrency

Conversation

@desrosj

@desrosj desrosj commented Nov 3, 2026

Copy link
Copy Markdown
Owner

What?

Keys the concurrency group of publish-npm-packages.yml to the wp_version input and stops it from canceling runs in progress. The group name matches the one on trunk for wp releases (npm-publish-wp-X.Y).

Commit: d712916

Why?

The current group is the pull request boilerplate: it is keyed to github.sha with cancel-in-progress: true. This workflow only runs on workflow_dispatch, so a second dispatch from the same commit cancels the first one at whatever step it has reached.

lerna publish patch commits the version bumps, tags them and pushes the commit and tags before it publishes to npm. A run canceled after that push leaves the branch tagged for versions that are not on npm. The next run then finds no changed packages, and the release has to be finished by hand with lerna publish from-package.

With this change:

  • Runs for the same WordPress version wait for each other instead of canceling, whichever branch they were dispatched from. This includes runs from trunk's copy of the workflow.
  • Only one run waits per group. A third dispatch replaces the pending run, which has not started yet.
  • A run waiting for approval of the WordPress packages environment holds the group until it is approved or rejected, and dry runs wait behind real runs.

queue: max, which trunk uses, is left out: actionlint does not recognize the key yet.

Testing Instructions

  • actionlint passes.
  • The diff only changes the concurrency block.

🤖 Generated with Claude Code

@desrosj
desrosj added this pull request to stack #886 November 3, 2026 00:09
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant