Repository navigation
wp/6.5: Serialize npm publishing runs per WordPress version without canceling them - #899
Open
desrosj wants to merge 1 commit into
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keys the
concurrencygroup ofpublish-npm-packages.ymlto thewp_versioninput and stops it from canceling runs in progress. The group name matches the one on trunk forwpreleases (npm-publish-wp-X.Y).Commit: d712916
Why?
The current group is the pull request boilerplate: it is keyed to
github.shawithcancel-in-progress: true. This workflow only runs onworkflow_dispatch, so a second dispatch from the same commit cancels the first one at whatever step it has reached.lerna publish patchcommits the version bumps, tags them and pushes the commit and tags before it publishes to npm. A run canceled after that push leaves the branch tagged for versions that are not on npm. The next run then finds no changed packages, and the release has to be finished by hand withlerna publish from-package.With this change:
WordPress packagesenvironment holds the group until it is approved or rejected, and dry runs wait behind real runs.queue: max, which trunk uses, is left out:actionlintdoes not recognize the key yet.Testing Instructions
actionlintpasses.concurrencyblock.🤖 Generated with Claude Code