Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds two inputs to
publish-npm-packages.ymlonwp/6.8:ignore_changes: extra space-separated globs that Lerna ignores when it detects changed packages.dry_run: runslerna changedwith the same options and lists the packages that would be published, without bumping, tagging, pushing or publishing anything.Commit: ea1f6d3
Why?
Lerna compares every package against the most recent release tag on the branch. When packages are published without Lerna, as in the October security release, no tag records them, so Lerna counts them as changed again and bumps them and every package that depends on them.
ignore_changeslets a release leave those packages out, anddry_runshows the list before anything is published.For the first release from this branch, the packages that were already published without tags on this branch can be left out with:
With those globs, Lerna lists
envande2e-tests. Once that release pushes its own tags, later releases do not needignore_changes.How?
--ignore-changesreplaces theignoreChangeslist inlerna.json, so the step repeats that list before adding the input's globs. The list is the same on everywp/X.Ybranch.lerna changedexits with 1 when no package changed. The dry run treats that one result as success and fails on any other error.envrather than being interpolated intorun.Testing Instructions
wp/6.9andwp/6.4(same step, Lerna 8.1.9 and 7.1.4): the dry run lists 23 packages with noignore_changes, and 2 and 4 packages with the globs above.No changed packages foundand succeeds.--not-a-real-flag) makes Lerna exit withUnknown arguments, and the step fails.actionlintpasses.🤖 Generated with Claude Code