Skip to content

Repair wp/5.1 branch Actions: Use pressWithModifier() in the list block e2e tests - #774

Closed
desrosj wants to merge 1 commit into
fix-actions-5.1/fix-rich-text-backport-formattingfrom
fix-actions-5.1/fix-list-test-modifier-helper
Closed

desrosj wants to merge 1 commit into
fix-actions-5.1/fix-rich-text-backport-formattingfrom
fix-actions-5.1/fix-list-test-modifier-helper

Conversation

@desrosj

@desrosj desrosj commented Oct 19, 2026

Copy link
Copy Markdown
Owner

What?

Changes ten calls in test/e2e/specs/blocks/list.test.js from pressKeyWithModifier() to pressWithModifier(), this branch's name for the same e2e helper.

Why?

npm run lint-js reports 'pressKeyWithModifier' is not defined (no-undef) ten times, and those list block end-to-end tests throw ReferenceError when they run.

WordPress@b9cac35cd64 ("RichText: List: Fix outdent with children (WordPress#13559)") was backported with the helper's later name. On this branch it is pressWithModifier(), which the file already imports and calls elsewhere.

How?

Both names take the same ( modifier, key ) arguments, and primaryShift, which four of the calls use, exists in this branch's @wordpress/keycodes. Nothing else changes.

Testing Instructions

Verified in a node:14.21.3 Linux x64 container on this branch: npm run lint-js passes (0 errors, 4 warnings). The end-to-end job runs the tests on this pull request.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SRW6hV7j7bc8cxt2LUbPJt

@desrosj
desrosj added this pull request to stack #763 October 19, 2026 21:52
@desrosj
desrosj removed this pull request from stack #763 October 20, 2026 17:24
@desrosj
desrosj force-pushed the fix-actions-5.1/fix-list-test-modifier-helper branch from 29701a5 to 84b5abb Compare October 20, 2026 17:24
@desrosj
desrosj added this pull request to stack #797 October 20, 2026 17:24
@desrosj
desrosj removed this pull request from stack #797 October 20, 2026 19:37
@desrosj
desrosj changed the base branch from fix-actions-5.1/fix-rich-text-backport-formatting to wp/5.1 October 20, 2026 19:37
@desrosj
desrosj force-pushed the fix-actions-5.1/fix-list-test-modifier-helper branch from 84b5abb to 5618a35 Compare October 20, 2026 19:38
@desrosj
desrosj changed the base branch from wp/5.1 to fix-actions-5.1/fix-rich-text-backport-formatting October 20, 2026 19:39
@desrosj
desrosj added this pull request to stack #812 October 20, 2026 19:39
@desrosj
desrosj removed this pull request from stack #812 October 20, 2026 23:59
@desrosj
desrosj changed the base branch from fix-actions-5.1/fix-rich-text-backport-formatting to wp/5.1 October 21, 2026 00:00
@desrosj
desrosj force-pushed the fix-actions-5.1/fix-list-test-modifier-helper branch from 5618a35 to 9cdab70 Compare October 21, 2026 00:01
@desrosj
desrosj changed the base branch from wp/5.1 to fix-actions-5.1/fix-rich-text-backport-formatting October 21, 2026 00:02
@desrosj
desrosj added this pull request to stack #827 October 21, 2026 00:02
@desrosj
desrosj removed this pull request from stack #827 October 21, 2026 02:38
@desrosj
desrosj added this pull request to stack #831 October 21, 2026 02:39
@desrosj
desrosj marked this pull request as ready for review October 26, 2026 18:57
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

…sts.

b9cac35 ("RichText: List: Fix outdent with children (WordPress#13559)") was
backported with ten calls to `pressKeyWithModifier()`, the name the helper
got later. On this branch it is `pressWithModifier()`, which the file already
imports and uses, so those tests throw `ReferenceError` and `npm run lint-js`
reports `no-undef`.

Call `pressWithModifier()`. Both names take the same `( modifier, key )`
arguments, and `primaryShift` exists in this branch's `@wordpress/keycodes`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SRW6hV7j7bc8cxt2LUbPJt
@desrosj
desrosj force-pushed the fix-actions-5.1/fix-list-test-modifier-helper branch from 9cdab70 to 56ecddf Compare October 26, 2026 19:13
@desrosj

desrosj commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#85672.

@desrosj desrosj closed this Oct 26, 2026
@desrosj
desrosj deleted the fix-actions-5.1/fix-list-test-modifier-helper branch October 29, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant