Repository navigation
Repair wp/5.1 branch Actions: Use pressWithModifier() in the list block e2e tests - #774
Closed
desrosj wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
desrosj
force-pushed
the
fix-actions-5.1/fix-list-test-modifier-helper
branch
from
October 20, 2026 17:24
29701a5 to
84b5abb
Compare
desrosj
changed the base branch from
fix-actions-5.1/fix-rich-text-backport-formatting
to
wp/5.1
October 20, 2026 19:37
desrosj
force-pushed
the
fix-actions-5.1/fix-list-test-modifier-helper
branch
from
October 20, 2026 19:38
84b5abb to
5618a35
Compare
desrosj
changed the base branch from
wp/5.1
to
fix-actions-5.1/fix-rich-text-backport-formatting
October 20, 2026 19:39
desrosj
changed the base branch from
fix-actions-5.1/fix-rich-text-backport-formatting
to
wp/5.1
October 21, 2026 00:00
desrosj
force-pushed
the
fix-actions-5.1/fix-list-test-modifier-helper
branch
from
October 21, 2026 00:01
5618a35 to
9cdab70
Compare
desrosj
changed the base branch from
wp/5.1
to
fix-actions-5.1/fix-rich-text-backport-formatting
October 21, 2026 00:02
desrosj
marked this pull request as ready for review
October 26, 2026 18:57
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…sts. b9cac35 ("RichText: List: Fix outdent with children (WordPress#13559)") was backported with ten calls to `pressKeyWithModifier()`, the name the helper got later. On this branch it is `pressWithModifier()`, which the file already imports and uses, so those tests throw `ReferenceError` and `npm run lint-js` reports `no-undef`. Call `pressWithModifier()`. Both names take the same `( modifier, key )` arguments, and `primaryShift` exists in this branch's `@wordpress/keycodes`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SRW6hV7j7bc8cxt2LUbPJt
desrosj
force-pushed
the
fix-actions-5.1/fix-list-test-modifier-helper
branch
from
October 26, 2026 19:13
9cdab70 to
56ecddf
Compare
Owner
Author
|
Moved to WordPress#85672. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changes ten calls in
test/e2e/specs/blocks/list.test.jsfrompressKeyWithModifier()topressWithModifier(), this branch's name for the same e2e helper.Why?
npm run lint-jsreports'pressKeyWithModifier' is not defined (no-undef)ten times, and those list block end-to-end tests throwReferenceErrorwhen they run.WordPress@b9cac35cd64 ("RichText: List: Fix outdent with children (WordPress#13559)") was backported with the helper's later name. On this branch it is
pressWithModifier(), which the file already imports and calls elsewhere.How?
Both names take the same
( modifier, key )arguments, andprimaryShift, which four of the calls use, exists in this branch's@wordpress/keycodes. Nothing else changes.Testing Instructions
Verified in a
node:14.21.3Linux x64 container on this branch:npm run lint-jspasses (0 errors, 4 warnings). The end-to-end job runs the tests on this pull request.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SRW6hV7j7bc8cxt2LUbPJt