Phase 1 initial - #1
Merged
Merged
Conversation
Comment on lines
+37
to
+41
| final List<Candle> candles; | ||
| final Tick animatedCurrentTick; | ||
| final double blinkAnimationProgress; | ||
| final int pipSize; | ||
| final ChartStyle style; |
There was a problem hiding this comment.
@ruskakimov please add documentation comment for all public properties.
Comment on lines
+70
to
+71
| Canvas canvas; | ||
| Size size; |
Comment on lines
+40
to
+50
| 0.1, | ||
| 0.25, | ||
| 0.5, | ||
| 1, | ||
| 2.5, | ||
| 5, | ||
| 10, | ||
| 25, | ||
| 50, | ||
| 100, | ||
| 250, |
There was a problem hiding this comment.
@ruskakimov please comment the logic behind these numbers.
| cp.xCenter + cp.width / 2, | ||
| cp.yOpen, | ||
| ), | ||
| Paint()..color = Color(0xFF00A79E), |
There was a problem hiding this comment.
@ruskakimov please let's use theming instead of hardcoding the colors.
18 tasks
18 tasks
18 tasks
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.