Feature: adding reel burning detection#47
Conversation
…r prompts 🎨 style(app): correct settings title typo in display settings 🔧 fix(monitor): implement reel burning detection with new method 🔧 fix(setting): add reel burning icon position to settings 🧹 chore(.gitignore): ignore IDE specific files by adding .idea/ 📦 upgrade(requirements): update prettytable version to 3.14.0
…etection 🎨 style(src/setting): adjust reel burning icon position for better alignment 🔧 refactor(src/monitor): update is_reel_burning method to return boolean instead of None
dereklee0310
left a comment
dereklee0310
left a comment
There was a problem hiding this comment.
Hi
Thanks for the pull request.
I have a few suggestions that need to be addressed:
- The link in app.py should remain unchanged.
- Please add the burning reel image to the folders under
static/for other languages. - Using
start.batto launch the script is an interesting approach, but it seems cumbersome to answer every prompt when only a few arguments are needed. I don't think we have to add it.
…update .gitignore to exclude it
|
|
LGTM |
…rning icon detection
…eel burning icon detection
yes im using it right now, i changed it to a tolerance value because it got problems detecting in the night. i still got some "overreactions" when the hand is moving under the symbol while pulling. |
|
Correct me if I'm wrong, but according to the tests I've done, seems like the color of the icons is not affected by lighting? |
…roved accuracy in UI elements
…date reel burning icon check logic
you was right, the "flickering" i assumed because of the transparency was because i got a wrong pixel position in the window. i corrected this and tested it with a feeder. it works like a charm now. |
2 participants
lookup commit messages for further insights.