Repository navigation
Remove the plaintext consume() path, add SecretVault.sign() - #26
Merged
Merged
Conversation
Port of qree PR #90 (merge f13911e). Gate::consume, the allow_plaintext_consume switch, Vault::retrieve_secret and the PyO3 consume binding are gone, so no operation on the in-process or broker interface returns a stored secret. SecretVault gains sign(token, payload), a thin wrapper over Gate::sign. Off the Rust backend sign() and invoke_llm() refuse and audit the refusal. Tests rewired: cargo 78 + 20 + 6, pytest 122 passed, 9 skipped.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the consume() removal from the development repo (PR #90 there).
What changes
Gate::consume, theallow_plaintext_consumeswitch and its chain event,Vault::retrieve_secretand the PyO3consumebinding are removed. No operation on the in-process or broker interface returns a stored secret anymore.SecretVault.sign(token, payload)is added, a thin wrapper overGate::sign. A token outside thesign.namespace is refused as the wrong operation class and the refusal lands on the chain asrejected_wrong_verb.sign()andinvoke_llm()refuse and appendsign_refused_no_rust_backend/invoke_refused_no_rust_backend.RustGate::newtakes onlyinsecure_dev_mode.Verification
Release 0.1.5 follows in a separate bump PR.