docs: add browser bundling guide - #7289
Conversation
There was a problem hiding this comment.
Thanks for picking this up, #4586 sat open for a long time. A few suggestions from me:
- CI is red:
deno task testtype-checks ts fences in markdown too. Mark both snippets```ts ignore(FAQ.md has the convention). - Prefer
deno bundle --platform browser -o dist/main.js main.tsas the primary path. @kt3k suggested the loader beforedeno bundlereturned in 2.4. - Swap the base64 example.
encodeBase64is most likely on its way out of std now thatUint8Array.fromBase64exists. You could use something from @std/text or @std/html instead. - The deno.json note is off: the loader resolves config from cwd or an explicit configPath, not the entry point. Moot if you switch to deno bundle.
- nit:
await esbuild.stop().
|
Thanks for the detailed review. I updated the guide to:
I also ran |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7289 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 617 617
Lines 51637 51637
Branches 9359 9359
=======================================
Hits 49075 49075
Misses 2021 2021
Partials 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I've addressed the feedback: added \ignore\ to the ts fences to fix CI, switched the primary example to use \deno bundle --platform browser, and swapped the base64 example for an \html\ escape example. Let me know if anything else is needed! |
Summary
esbuild-deno-loaderintegration with a complete entry point and build scriptdeno.jsonimport-map discoveryCloses #4586
Validation
deno fmt --check README.mddist/main.jsgit diff --check