Vite Plugin has no hook filters

[TheAlexLichter]

Hey all 👋

Congrats on the Vite plugin release for fresh. I've noticed that e.g. the transform hook has no hook filter yet while still including certain file types only. Hook filters would improve performance with rolldown-vite (and the next Vite major version).
Also, you might want to look into using oxc-transform for JSX parsing if rolldown-vite is detected (or in general?)

See also:

• https://vite.dev/guide/rolldown.html#hook-filter-feature
• Add hook filter rules to vite, rollup and unplugin plugins e18e/ecosystem-issues#171

[marvinhagemeister]

Happy to add these. Do you still need to release a new version though? I can't find typings for the moduleType property.

[marvinhagemeister]

Gave this a go, but it looks like it changes the handling of namespaced modules with the \0 byte, see #3333

[TheAlexLichter]

Happy to add these. Do you still need to release a new version though? I can't find typings for the moduleType property.

(moduleType is not supported in plain Vite yet, related vitejs/vite#21945)

[TheAlexLichter]

Gave this a go, but it looks like it changes the handling of namespaced modules with the \0 byte, see #3333

Strings are meant to be used as glob. If you want an exact match, a Regex would be better (you can use https://www.npmjs.com/package/@rolldown/pluginutils or rollup/plugins#1865 which includes helpers for that)

[csvn]

Also, you might want to look into using oxc-transform for JSX parsing if rolldown-vite is detected (or in general?)

@TheAlexLichter With oxc-transform, are you referring to transformWithOxc?

[TheAlexLichter]

Also, you might want to look into using oxc-transform for JSX parsing if rolldown-vite is detected (or in general?)

@TheAlexLichter With oxc-transform, are you referring to transformWithOxc?

yeah (or the transformWithEsbuild equivalent for plain Vite) 🤔

If that doesnt work for you, using Oxc-transformer manually would work too I suppose

[csvn]

Cool. Making the Fresh Vite Plugin compatible with rolldown-vite, both for future-proofing and faster development, is something I'm very interested in. Using babel might work for both, but if possible it would be great to re-use oxc as much as possible when using rolldown-vite.