feat(type): make Float16Array generic (Merge after importing TypeScript 5.7)#26937
Closed
petamoriken wants to merge 2 commits intodenoland:mainfrom
Closed
feat(type): make Float16Array generic (Merge after importing TypeScript 5.7)#26937petamoriken wants to merge 2 commits intodenoland:mainfrom
Float16Array generic (Merge after importing TypeScript 5.7)#26937petamoriken wants to merge 2 commits intodenoland:mainfrom
Conversation
petamoriken
changed the title
Float16Array genericFloat16Array generic (Merge after importing TypeScript 5.7)
Contributor
|
Included with you as a co-author in 8971064 (couldn't get that compiling without this). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 5.7 (released on 2024-11-21) will make TypedArrays Generic, so update the type of
Float16Arrayaccording to that change.Since the PR submitted to TypeScript (microsoft/TypeScript#60151) will not be ready for TypeScript 5.7, this change should be imported directly to the Deno side.