Mailers need separate tests #627

Activity

1. denny

   added

   good first issueThis issue should be suitable for less experienced developersThis issue should be suitable for less experienced developers

   pluginDEPRECATED: split into core/features/support (was: about a plugin or the code that supports them)DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them)

   testsTests and test infrastructure (CI, etc)Tests and test infrastructure (CI, etc)

   main appDEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins)DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins)

   mjmlInvolves MJML, or the code that handles itInvolves MJML, or the code that handles it

   help wantedCan you help with this?Can you help with this?

   help offeredI would be very happy to help less experienced developers tackle this issue (advice/pairing/etc)I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc)

   on Oct 6, 2020
2. denny commented on Oct 10, 2020

   

   denny

   on Oct 10, 2020

   OwnerAuthor

   More actions

   If you are a less experienced developer who is looking at this issue and thinking you'd like to try to take it on but you're not entirely confident, I would be happy to help you - whether that's help getting set up, more explanation of what needs doing, pairing on the code task itself, or anything else I can do to help.

   In my day job I'm a lead developer who often mentors less experienced developers, and I'd love to use some of that experience to help people take their first steps into contributing to open source projects.
3. denny commented on Nov 3, 2020

   

   denny

   on Nov 3, 2020

   Last edited by denny

   OwnerAuthor

   More actions

   I just added basic mailer tests for ShinyForms[1] while I was fixing another issue in that plugin. DiscussionMailer and EmailRecipientMailer in the main app already have tests.

   That leaves the following mailers still in need of separate tests:

   • UserMailer
   • ShinyNewsletters::NewsletterMailer

   [1] https://github.com/denny/ShinyCMS-ruby/blob/main/plugins/ShinyForms/spec/mailers/shiny_forms/form_mailer_spec.rb
4. denny

   removed

   help wantedCan you help with this?Can you help with this?

   on Nov 13, 2020