Promote network error logging to Warning across all HTTP enrichers#196
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 27361927000Coverage decreased (-0.05%) to 77.686%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
…nd NpmRegistryMetadataFetcher Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
All HTTP-based enrichers and fetchers now surface network failures at
Warninglevel instead of swallowing them atDebug.GitHubRepositoryRiskEnricher— HTTP 403 (rate limit exceeded) responses from the GitHub API were previously swallowed into a catch-allExceptionhandler and logged atDebuglevel. A dedicatedcatch (HttpRequestException ex) when (ex.StatusCode == Forbidden)clause now logs these atWarning. Other exceptions (e.g. 404, connectivity errors) remain atDebugto avoid noise.LicenseUrlRiskEnricher— network failures while validating a package's license URL were logged atDebug; promoted toWarning.NpmRegistryMetadataFetcher— failures fetching the npm download count were logged atDebugwith a string-interpolated message; promoted toWarningand aligned to pass the exception object (consistent with structured logging elsewhere).The following were already correct and required no changes:
OsvRiskEnricher,NpmRegistryMetadataFetcher.FetchMetadataAsync,UrlLicenseFetcher, andGitHubLicenseFetcher(covered byLicenseFetcher.TryFetchLicenseAsync).Why
Network errors that prevent meaningful package analysis are actionable — they tell the user something is wrong (rate limit hit, unreachable endpoint, bad URL). Surfacing them as
Warningmakes them visible in normal operation without requiring debug logging to be enabled.🤖 Generated with Claude Code