Re-enable Roslyn analyzers (AV/MA/SA) and fix all reported issues#189
Open
dennisdoomen wants to merge 1 commit into
Open
Re-enable Roslyn analyzers (AV/MA/SA) and fix all reported issues#189dennisdoomen wants to merge 1 commit into
dennisdoomen wants to merge 1 commit into
Conversation
Co-authored-by: Junie <junie@jetbrains.com>
dennisdoomen
force-pushed
the
dennisdoomen/fix-roslyn-analyzers
branch
from
20eea37 to
0e66129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the CSharpGuidelines (AV), Meziantou (MA), and StyleCop (SA) Roslyn analyzers and fixes all reported errors and warnings so the build is fully clean.
Build errors fixed
SecurityRiskEvaluator,PackageAdoptionRiskFactor,GitHubRepositoryRiskEnricher,IssueHealthRiskFactor,NpmRegistryMetadataFetcher,RiskHtmlReportWriter,AnalyzeCommandDependencyHealthCountEnricher.CountDependencyHealthreplaced 4-element tuple with newDependencyHealthCountsrecordWarnings fixed
elseclauses to if-else-if chainsnulldefault fromLicenseFetcherconstructorCommonFileDetectorrenamed to avoid 'Common' in type nameStringComparerto dictionary/set constructorsApplicationExceptionwithInvalidOperationExceptionList<T>field types toIList<T>StringComparison.OrdinaltoStartsWithcallsVerification
dotnet buildcompletes with 0 errors and 0 warnings. 161/163 tests pass; the 1 failure (Can_analyze_yarn_projects_without_lock_file) is a pre-existing environment issue (yarnnot installed) unrelated to these changes.