Skip to content

Fix for puppeteer/chrome.#89

Merged
Malcolmnixon merged 1 commit into
mainfrom
puppeteer-fix
Jun 6, 2026
Merged

Fix for puppeteer/chrome.#89
Malcolmnixon merged 1 commit into
mainfrom
puppeteer-fix

Conversation

@Malcolmnixon

Copy link
Copy Markdown
Member

Pull Request

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully and all tests pass: pwsh ./build.ps1
  • Code produces zero warnings

Code Quality

  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: pwsh ./lint.ps1

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated docs/ documentation (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings June 6, 2026 02:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the build-docs GitHub Actions workflow on Windows to help Mermaid/Puppeteer locate a Chrome executable during document generation.

Changes:

  • Adds a PowerShell step to set PUPPETEER_EXECUTABLE_PATH to a system Chrome path on Windows.
  • Minor formatting/continuation adjustment in the tool-version capture command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
@Malcolmnixon Malcolmnixon merged commit cf3854a into main Jun 6, 2026
16 checks passed
@Malcolmnixon Malcolmnixon deleted the puppeteer-fix branch June 6, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants